qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Giuseppe Musacchio <thatlemon@gmail.com>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2 2/4] linux-user/sparc: Remove unneeded checks of 'err' from sparc64_get_context()
Date: Fri, 6 Nov 2020 09:10:10 -0800	[thread overview]
Message-ID: <c921cac7-92db-cbcb-b0c2-4d30d3c161bb@linaro.org> (raw)
In-Reply-To: <20201106152738.26026-3-peter.maydell@linaro.org>

On 11/6/20 7:27 AM, Peter Maydell wrote:
> Unlike the kernel macros, our __get_user() and __put_user() do not
> return a failure code.  Kernel code typically has a style of
>   err |= __get_user(...); err |= __get_user(...);
> and then checking err at the end.  In sparc64_get_context() our
> version of the code dropped the accumulating into err but left the
> "if (err) goto do_sigsegv" checks, which will never be taken. Delete
> unnecessary if()s.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  linux-user/sparc/signal.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



  reply	other threads:[~2020-11-06 17:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 15:27 [PATCH v2 0/4] linux/sparc: more get/set_context fixes Peter Maydell
2020-11-06 15:27 ` [PATCH v2 1/4] linux-user/sparc: Correct sparc64_get/set_context() FPU handling Peter Maydell
2020-11-06 17:09   ` Richard Henderson
2020-11-06 17:10     ` Peter Maydell
2020-12-17 11:30     ` Laurent Vivier
2020-11-06 15:27 ` [PATCH v2 2/4] linux-user/sparc: Remove unneeded checks of 'err' from sparc64_get_context() Peter Maydell
2020-11-06 17:10   ` Richard Henderson [this message]
2020-12-17 11:32   ` Laurent Vivier
2020-11-06 15:27 ` [PATCH v2 3/4] linux-user/sparc: Don't restore %g7 in sparc64_set_context() Peter Maydell
2020-11-06 17:11   ` Richard Henderson
2020-12-17 11:33   ` Laurent Vivier
2020-11-06 15:27 ` [PATCH v2 4/4] linux-user/sparc: Handle tstate in sparc64_get/set_context() Peter Maydell
2020-11-06 17:22   ` Richard Henderson
2020-12-17 11:33   ` Laurent Vivier
2020-11-06 15:30 ` [PATCH v2 0/4] linux/sparc: more get/set_context fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c921cac7-92db-cbcb-b0c2-4d30d3c161bb@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thatlemon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).