qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, ysato@users.sourceforge.jp
Subject: Re: [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log
Date: Wed, 29 Sep 2021 17:03:52 +0200	[thread overview]
Message-ID: <c9c6c642-eb01-05b0-ed9d-4b8539b7f2ae@vivier.eu> (raw)
In-Reply-To: <20210929130316.121330-1-richard.henderson@linaro.org>

Le 29/09/2021 à 15:03, Richard Henderson a écrit :
> The correct thing to do has been present but commented
> out since the initial commit of the sh4 translator.
> 
> Fixes: fdf9b3e831e
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/sh4/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
> index cf5fe9243d..d363050272 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -2344,7 +2344,7 @@ static void sh4_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
>  
>  static void sh4_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs)
>  {
> -    qemu_log("IN:\n");  /* , lookup_symbol(dcbase->pc_first)); */
> +    qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first));
>      log_target_disas(cs, dcbase->pc_first, dcbase->tb->size);
>  }
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent



      parent reply	other threads:[~2021-09-29 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 13:03 [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log Richard Henderson
2021-09-29 13:42 ` Philippe Mathieu-Daudé
2021-09-29 15:03 ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9c6c642-eb01-05b0-ed9d-4b8539b7f2ae@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).