From: Eric Blake <eblake@redhat.com>
To: Zhengui li <lizhengui@huawei.com>,
pbonzini@redhat.com, stefanha@redhat.com, mreitz@redhat.com,
kwolf@redhat.com
Cc: xieyingtai@huawei.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert
Date: Mon, 19 Oct 2020 15:13:08 -0500 [thread overview]
Message-ID: <c9cc09b4-517e-2aa0-3099-d991ca4c0713@redhat.com> (raw)
In-Reply-To: <1603002879-26288-1-git-send-email-lizhengui@huawei.com>
On 10/18/20 1:34 AM, Zhengui li wrote:
> From: Zhengui <lizhengui@huawei.com>
>
> Currently, there is no rate limit for qemu-img convert. This may
> cause the task of qemu-img convert to consume all the bandwidth
> of the storage. This will affect the IO performance of other processes
> and virtual machines under shared storage. So we add support for
> offline rate limit in qemu-img convert to get better quality of sevice.
>
service
Also, I'd suggest bundling your related patches into a 0/N series (it
took me a while to notice that you had two separate emails, one for
commit and one for convert, sent at nearly the same time, because the
subject line was long enough to truncate the important part in my view-pane)
> Signed-off-by: Zhengui <lizhengui@huawei.com>
> ---
> qemu-img-cmds.hx | 4 ++--
> qemu-img.c | 34 +++++++++++++++++++++++++++++++++-
> 2 files changed, 35 insertions(+), 3 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-10-19 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 6:34 [PATCH] qemu-img: add support for rate limit in qemu-img convert Zhengui li
2020-10-19 11:45 ` Alberto Garcia
2020-10-19 20:13 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-18 5:36 Zhengui li
2020-10-18 5:42 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9cc09b4-517e-2aa0-3099-d991ca4c0713@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhengui@huawei.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xieyingtai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).