From: Thomas Huth <thuth@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "Ed Maste" <emaste@freebsd.org>,
qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"qemu devel list" <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Giuseppe Lettieri" <giuseppe.lettieri@unipi.it>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Vincenzo Maffione" <vmaffione@freebsd.org>
Subject: Re: [PATCH] Test netmap on FreeBSD
Date: Tue, 8 Oct 2019 11:57:16 +0200 [thread overview]
Message-ID: <cba34788-503c-775a-3748-2de3ff995043@redhat.com> (raw)
In-Reply-To: <CAGxU2F61+TjSy_GJ_2673--VLstVyJjNoqqPdZw+ej22xbzk=Q@mail.gmail.com>
On 08/10/2019 11.48, Stefano Garzarella wrote:
> Hi Thomas,
>
> On Tue, Oct 8, 2019 at 10:49 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>> FreeBSD offers a package for "netmap", thus let's install it in our
>> FreeBSD tests to get some compile test coverage for net/netmap.c, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> .cirrus.yml | 2 +-
>> tests/vm/freebsd | 3 +++
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/.cirrus.yml b/.cirrus.yml
>> index 8326a3a4b1..44fea2c29e 100644
>> --- a/.cirrus.yml
>> +++ b/.cirrus.yml
>> @@ -8,7 +8,7 @@ freebsd_12_task:
>> memory: 8G
>> install_script: pkg install -y
>> bash bison curl cyrus-sasl git glib gmake gnutls gsed
>> - nettle perl5 pixman pkgconf png usbredir
>> + netmap nettle perl5 pixman pkgconf png usbredir
>
>> script:
>> - mkdir build
>> - cd build
>> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
>> index 2a19461a90..45821702bd 100755
>> --- a/tests/vm/freebsd
>> +++ b/tests/vm/freebsd
>> @@ -54,6 +54,9 @@ class FreeBSDVM(basevm.BaseVM):
>> # libs: opengl
>> "libepoxy",
>> "mesa-libs",
>> +
>> + # libs: network
>> + "netmap",
>
> IIRC netmap is shipped with the FreeBSD kernel, so we shouldn't need to
> install it.
>
> I tried to understand what is the 'netmap' pkg and I found the following
> in my FreeBSD 12 VM:
>
> # pkg search netmap
> netmap-0.1.3_1 Make a graphical representation of the surrounding network
>
> I don't think we are installing the right 'netmap' (I know, it is a bit
> confusing :) )
>
> I'll tried "make vm-build-freebsd" without this patch and I noticed
> "netmap support yes" in the configure output. So I think we're
> already compiling the netmap backend in the 'vm-buil-freebsd' target and
> maybe also in cirrus.
Oops, I think you're right. I just checked an older build on cirrus-ci
(without this patch), and indeed, it also says "netmap support yes"
in the output of "configure". So we already have a compile test for
netmap :-)
Thus, please disregard this patch, it's not necessary indeed.
Thomas
prev parent reply other threads:[~2019-10-08 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:49 [PATCH] Test netmap on FreeBSD Thomas Huth
2019-10-08 9:48 ` Stefano Garzarella
2019-10-08 9:52 ` Li-Wen Hsu
2019-10-08 17:07 ` Vincenzo Maffione
2019-10-08 17:12 ` Vincenzo Maffione
2019-10-08 9:57 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba34788-503c-775a-3748-2de3ff995043@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=emaste@freebsd.org \
--cc=giuseppe.lettieri@unipi.it \
--cc=lwhsu@freebsd.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=vmaffione@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).