From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A32C433B4 for ; Wed, 7 Apr 2021 12:07:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6112661260 for ; Wed, 7 Apr 2021 12:07:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6112661260 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU6yN-0003CZ-9h for qemu-devel@archiver.kernel.org; Wed, 07 Apr 2021 08:07:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU6x8-0002Sh-Oi; Wed, 07 Apr 2021 08:06:34 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:47107) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU6x2-0006Ez-Ti; Wed, 07 Apr 2021 08:06:34 -0400 Received: from [192.168.100.1] ([82.142.14.126]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MJEtx-1lAfUE0fhz-00KgT6; Wed, 07 Apr 2021 14:06:21 +0200 To: Stefan Weil , Bin Meng , Peter Maydell , "qemu-devel@nongnu.org Developers" , QEMU Trivial , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Alistair Francis References: <20210326062140.367861-1-bmeng.cn@gmail.com> From: Laurent Vivier Subject: Re: [PATCH] nsis: Install *.elf images Message-ID: Date: Wed, 7 Apr 2021 14:06:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:b045qct/GSz6fSjRkn5aFyF20K3VsYGEPoIYQ4lF0hPwlXaadK3 EY2m7VsisxWFGJy/S6FVxGlGsLeRDqwEe9gRKGpgjHuNQVqtZ2PAVpHJq7CYbT/ARh6MAoh pkxsoD6iUKDT2ErO16haXH3UF+pNW6efV9WUPJ52oTgJ9rPZmPN7xZ1Kiluu2bfRH6Bzj7M ThbALKguo+h3s98sw++1A== X-UI-Out-Filterresults: notjunk:1;V03:K0:Zp3/Jj/BxDo=:2XtbYldoOaR08Cnhyodh6+ zTNMCkeNOA0X2SvNpPWV/0H8v0Cq9x89GFuGcazhFqPdDenBwEmYkLHfRgAaHvqVWHzgy26Kn WptRivA3uOxqS39bd+Fhx6cx4BVY8KgBmYxS2wIBybIfzyY+o92yPfOcKisQ4bxvb09YUvP1P UTI5V6bv1618NnYcyB/UEd3R34HGNcOmS06WALoc/PGrfoBr+3MZeLnbsJkThUp4kYyVrDYWz axFCfGxJvYbNDg7aK6dvJf3YDFdmzsY1rMi/1AdkgWsSx2HT+AFhaEBoTCXRcEPpiSQX1WTiE xTyO2WQNAG1u0XeMQtsMSfnkiZ3BAn2BET0lXSuwrlfBxAe8H5eweJccBQ0h0a+WTkmB+hThW U8Q67JIAlurhEe89jzoKklgGoyAzoS2Lhuk+cG0pm6l+K4dnsjDS5ByYAASyGEHbEDazAPDV3 Q808CUrGnbnMvj1heuzlvJdxZLkfn4sx65IX8kBpawN/i4BZMKV0 Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 06/04/2021 à 11:28, Stefan Weil a écrit : > Am 06.04.21 um 11:04 schrieb Bin Meng: > >> On Fri, Mar 26, 2021 at 2:22 PM Bin Meng wrote: >>> As of today, the QEMU Windows installer does not include the >>> following two RISC-V BIOS images: >>> >>> - opensbi-riscv64-generic-fw_dynamic.elf >>> - opensbi-riscv32-generic-fw_dynamic.elf >>> >>> Update the installer script to include them. >>> >>> Signed-off-by: Bin Meng >>> >>> --- >>> Based on: >>> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c >>> >>> The above commit does not land on QEMU master. I am not sure what >>> the process is, sending it here for comments. >>> >>>   qemu.nsi | 2 ++ >>>   1 file changed, 2 insertions(+) >> Ping? > > > Reviewed-by: Stefan Weil > > This is a small uncritical fix which can be merged via QEMU trivial. If it is merged via QEMU trivial, it will be after the 6.0 release. If it's needed for 6.0 it's better to go via the maintainer tree (W32,W64) [1] Thanks, Laurent [1] the reason is: even a trivial change can break something, I don't like to break QEMU during RC phase, so going via the maintainer tree helps to have tests more relevant to the area that is modified.