From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Cc: armbru@redhat.com
Subject: Re: [PATCH for-6.0?] qga: fix guest-get-disks regression
Date: Tue, 20 Apr 2021 15:12:15 +0200 [thread overview]
Message-ID: <cc5b1a9f-dc68-b336-e281-41ca33e85286@redhat.com> (raw)
In-Reply-To: <20210420125831.233092-1-marcandre.lureau@redhat.com>
On 4/20/21 2:58 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 4299ebd96f..75dbaab68e 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
> partition = g_new0(GuestDiskInfo, 1);
> partition->name = dev_name;
> partition->partition = true;
> + partition->has_dependencies = true;
> /* Add parent disk as dependent for easier tracking of hierarchy */
> QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-04-20 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 12:58 [PATCH for-6.0?] qga: fix guest-get-disks regression marcandre.lureau
2021-04-20 13:04 ` Daniel P. Berrangé
2021-04-20 13:12 ` Philippe Mathieu-Daudé [this message]
2021-04-20 15:03 ` Markus Armbruster
2021-04-20 15:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc5b1a9f-dc68-b336-e281-41ca33e85286@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).