From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module
Date: Fri, 23 Aug 2019 14:03:54 +0200 [thread overview]
Message-ID: <ce54cd4e-182c-6ae7-6b47-65ae028e749e@redhat.com> (raw)
In-Reply-To: <CAJ+F1CKx_B9nFAaAdNbWAdsim7LUvSEY06mR-b_Ngya79iwoSg@mail.gmail.com>
On 23/08/19 09:32, Marc-André Lureau wrote:
> On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so
>> ui-spice-app is always linked into QEMU.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> I would rather build the module:
> -common-obj-$(call land,$(CONFIG_SPICE),$(CONFIG_GIO)) += spice-app.mo
> +ifeq ($(CONFIG_GIO)$(CONFIG_SPICE),yy)
> +common-obj-$(if $(CONFIG_MODULES),m,y) += spice-app.mo
> +endif
That would not be a quick patch that Peter can apply to fix the build...
Paolo
next prev parent reply other threads:[~2019-08-23 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module Paolo Bonzini
2019-08-23 7:32 ` Marc-André Lureau
2019-08-23 12:03 ` Paolo Bonzini [this message]
2019-08-23 12:32 ` Miroslav Rezanina
2019-08-23 14:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce54cd4e-182c-6ae7-6b47-65ae028e749e@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).