From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30693CA9EC5 for ; Wed, 30 Oct 2019 16:50:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2DE12087E for ; Wed, 30 Oct 2019 16:50:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BXWrBf6/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2DE12087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPrAh-00049X-UN for qemu-devel@archiver.kernel.org; Wed, 30 Oct 2019 12:50:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60351) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPr8Z-0002rB-BP for qemu-devel@nongnu.org; Wed, 30 Oct 2019 12:48:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPr8V-0003ip-S3 for qemu-devel@nongnu.org; Wed, 30 Oct 2019 12:47:57 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:29341 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPr8V-0003hO-JJ for qemu-devel@nongnu.org; Wed, 30 Oct 2019 12:47:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572454074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=48DTnxo0G6QBt89/rudxjbuvMtdy1hw+5xe5w3w9jCo=; b=BXWrBf6/qDqQUew0MViJ5JWFwOPNprk+jvgNdypvvubNGKz8SA9zWQCkZNVX3A1j9qZTzF UVOhszLnuJxwx2/fzqBB+flCqMvto3DOPjZgTV7/TaGb6C3bTpfSCSh4g/iCe2jLqwcDgJ 8iG5Aewsi4Gk+kngLMIPC5II/Oyj2T4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-Q8N-MK51PZGZb4fvn9NDKw-1; Wed, 30 Oct 2019 12:47:51 -0400 X-MC-Unique: Q8N-MK51PZGZb4fvn9NDKw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E5325E4; Wed, 30 Oct 2019 16:47:50 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-117-147.ams2.redhat.com [10.36.117.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58C37261CF; Wed, 30 Oct 2019 16:47:46 +0000 (UTC) Subject: Re: [RFC PATCH v2 09/26] qcow2: Add l2_entry_size() To: Alberto Garcia , qemu-devel@nongnu.org References: <25d88362166db95ddafdff854ba1e4cde1504428.1572125022.git.berto@igalia.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Wed, 30 Oct 2019 17:47:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <25d88362166db95ddafdff854ba1e4cde1504428.1572125022.git.berto@igalia.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V2AgCqMwgPA3X3P87YZjNsFSW9zCNFmqb" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V2AgCqMwgPA3X3P87YZjNsFSW9zCNFmqb Content-Type: multipart/mixed; boundary="v3kZsElt9cB0rlBIEjX39sYyIquDUEjn8" --v3kZsElt9cB0rlBIEjX39sYyIquDUEjn8 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 26.10.19 23:25, Alberto Garcia wrote: > qcow2 images with subclusters have 128-bit L2 entries. The first 64 > bits contain the same information as traditional images and the last > 64 bits form a bitmap with the status of each individual subcluster. >=20 > Because of that we cannot assume that L2 entries are sizeof(uint64_t) > anymore. This function returns the proper value for the image. >=20 > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 12 ++++++------ > block/qcow2-refcount.c | 14 ++++++++------ > block/qcow2.c | 6 +++--- > block/qcow2.h | 5 +++++ > 4 files changed, 22 insertions(+), 15 deletions(-) I suppose qcow2_calc_prealloc_size(), qcow2_co_truncate() (nb_new_l2_tables), and qcow2_measure() (l2_tables) also need some adjustment. Max --v3kZsElt9cB0rlBIEjX39sYyIquDUEjn8-- --V2AgCqMwgPA3X3P87YZjNsFSW9zCNFmqb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl25vrAACgkQ9AfbAGHV z0DH5Qf/Y14WbVnd14seqEmqkRr+2dPNUM0aAF6CQIYm8Xb4SMF1os3ti/XnNTKO QFQY84j6UtjifzVkB1Pvyrr4+RsOoFjPI5A1vFbu8JUl4PUZ25rkyOGeIpYBvqTc E7hijx3VubBfBAlXaVrCq8ZTiGrB+ysPz7zuy9VzY1GglspQjkMM5n4RUdBUcc8F Fp//7AueH7mwGNp5JSrY+otJ6iTNiy1+1T+o6Z4y9LqbKc3ewnA/BtlFyedW2G1/ gSeAUQ1Au2za9r1StseNTd3NRC3fBlWTYqiACBFvWM8eRPlYtimsJfDuOEdTR7d9 TalLo7nnWF2sYDTMn/oJPn0LwWlTXQ== =jPfq -----END PGP SIGNATURE----- --V2AgCqMwgPA3X3P87YZjNsFSW9zCNFmqb--