From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE97C433B4 for ; Tue, 6 Apr 2021 09:29:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78BFE613C2 for ; Tue, 6 Apr 2021 09:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78BFE613C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=weilnetz.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTi1U-0000YU-0u for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 05:29:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTi0R-0008Nk-8v; Tue, 06 Apr 2021 05:28:19 -0400 Received: from mail.weilnetz.de ([37.120.169.71]:33068 helo=mail.v2201612906741603.powersrv.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTi0O-0005P8-MC; Tue, 06 Apr 2021 05:28:18 -0400 Received: from macbook02.fritz.box (p5b1511bf.dip0.t-ipconnect.de [91.21.17.191]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.v2201612906741603.powersrv.de (Postfix) with ESMTPSA id 53201DA0491; Tue, 6 Apr 2021 11:28:12 +0200 (CEST) To: Bin Meng , Peter Maydell , "qemu-devel@nongnu.org Developers" , QEMU Trivial , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Alistair Francis References: <20210326062140.367861-1-bmeng.cn@gmail.com> From: Stefan Weil Subject: Re: [PATCH] nsis: Install *.elf images Message-ID: Date: Tue, 6 Apr 2021 11:28:09 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=37.120.169.71; envelope-from=sw@weilnetz.de; helo=mail.v2201612906741603.powersrv.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 06.04.21 um 11:04 schrieb Bin Meng: > On Fri, Mar 26, 2021 at 2:22 PM Bin Meng wrote: >> As of today, the QEMU Windows installer does not include the >> following two RISC-V BIOS images: >> >> - opensbi-riscv64-generic-fw_dynamic.elf >> - opensbi-riscv32-generic-fw_dynamic.elf >> >> Update the installer script to include them. >> >> Signed-off-by: Bin Meng >> >> --- >> Based on: >> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275= ba307ff6c >> >> The above commit does not land on QEMU master. I am not sure what >> the process is, sending it here for comments. >> >> qemu.nsi | 2 ++ >> 1 file changed, 2 insertions(+) > Ping? Reviewed-by: Stefan Weil This is a small uncritical fix which can be merged via QEMU trivial. As Philippe already mentioned, a more advanced solution would only=20 install the required binaries, but typically the NSIS installer is built = with all system emulations, so it requires all available blobs.=20 Thererfore the current solution is fine for now. Regards, Stefan