From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] disas/libvixl: Protect C system header for C++ compiler
Date: Sun, 16 May 2021 14:40:27 +0200 [thread overview]
Message-ID: <ceb7fcb9-8b17-5fd7-00a6-9daa3cc6a806@amsat.org> (raw)
In-Reply-To: <20210515183531.372925-1-f4bug@amsat.org>
Forgot to tag as RFC.
Cc'ing mjt to have feedback from Debian packaging.
On 5/15/21 8:35 PM, Philippe Mathieu-Daudé wrote:
> When selecting an ARM target on Debian unstable, we get:
>
> Compiling C++ object libcommon.fa.p/disas_libvixl_vixl_utils.cc.o
> FAILED: libcommon.fa.p/disas_libvixl_vixl_utils.cc.o
> c++ -Ilibcommon.fa.p -I. -I.. [...] -o libcommon.fa.p/disas_libvixl_vixl_utils.cc.o -c ../disas/libvixl/vixl/utils.cc
> In file included from /home/philmd/qemu/disas/libvixl/vixl/utils.h:30,
> from ../disas/libvixl/vixl/utils.cc:27:
> /usr/include/string.h:36:43: error: missing binary operator before token "("
> 36 | #if defined __cplusplus && (__GNUC_PREREQ (4, 4) \
> | ^
> /usr/include/string.h:53:62: error: missing binary operator before token "("
> 53 | #if defined __USE_MISC || defined __USE_XOPEN || __GLIBC_USE (ISOC2X)
> | ^
> /usr/include/string.h:165:21: error: missing binary operator before token "("
> 165 | || __GLIBC_USE (LIB_EXT2) || __GLIBC_USE (ISOC2X))
> | ^
> /usr/include/string.h:174:43: error: missing binary operator before token "("
> 174 | #if defined __USE_XOPEN2K8 || __GLIBC_USE (LIB_EXT2) || __GLIBC_USE (ISOC2X)
> | ^
> /usr/include/string.h:492:19: error: missing binary operator before token "("
> 492 | #if __GNUC_PREREQ (3,4)
> | ^
>
> Similarly to commit 875df03b221 ('osdep: protect qemu/osdep.h with
> extern "C"'), guard the <string.h> system header with 'extern "C"'.
>
> Relevant information from the host:
>
> $ lsb_release -d
> Description: Debian GNU/Linux 11 (bullseye)
> $ gcc --version
> gcc (Debian 10.2.1-6) 10.2.1 20210110
> $ dpkg -S /usr/include/string.h
> libc6-dev: /usr/include/string.h
> $ apt-cache show libc6-dev
> Package: libc6-dev
> Version: 2.31-11
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1914870
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC because I've no idea about C++, but this fixes the build for me.
>
> Quick reproducer:
>
> $ ../configure --disable-tools --target-list=aarch64-linux-user
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> ---
> disas/libvixl/vixl/utils.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/disas/libvixl/vixl/utils.h b/disas/libvixl/vixl/utils.h
> index 5ab134e240a..fc28d7456c1 100644
> --- a/disas/libvixl/vixl/utils.h
> +++ b/disas/libvixl/vixl/utils.h
> @@ -27,8 +27,10 @@
> #ifndef VIXL_UTILS_H
> #define VIXL_UTILS_H
>
> -#include <string.h>
> #include <cmath>
> +extern "C" {
> +#include <string.h>
> +}
> #include "vixl/globals.h"
> #include "vixl/compiler-intrinsics.h"
>
>
next prev parent reply other threads:[~2021-05-16 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 18:35 [PATCH] disas/libvixl: Protect C system header for C++ compiler Philippe Mathieu-Daudé
2021-05-16 12:40 ` Philippe Mathieu-Daudé [this message]
2021-05-16 12:46 ` Thomas Huth
2021-05-16 17:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb7fcb9-8b17-5fd7-00a6-9daa3cc6a806@amsat.org \
--to=f4bug@amsat.org \
--cc=berrange@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).