From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
Greg Kurz <groug@kaod.org>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v4 00/12] 9pfs: add tests using local fs driver
Date: Thu, 8 Oct 2020 20:49:16 +0200 [thread overview]
Message-ID: <cover.1602182956.git.qemu_oss@crudebyte.com> (raw)
The currently existing 9pfs test cases are all solely using the 9pfs 'synth'
fileystem driver, which is a very simple and purely simulated (in RAM only)
filesystem. There are issues though where the 'synth' fs driver is not
sufficient. For example the following two bugs need test cases running the
9pfs 'local' fs driver:
https://bugs.launchpad.net/qemu/+bug/1336794
https://bugs.launchpad.net/qemu/+bug/1877384
This patch set for that reason introduces 9pfs test cases using the 9pfs
'local' filesystem driver along to the already existing tests on 'synth'.
It consists of 3 parts:
1. libqos patches 1 and 2 remove a limitation of the qtest/libqos subsystem:
support for more than one device using the same (official) QEMU device
name.
2. Patches 3 to 7 enhance debugging issues with the qtest framework.
3. Patches 8 to 12 actually introduce 9pfs 'local' test cases using the qtest
framework. These 'local' tests are adding a test directory 'qtest-9p-local'
inside the current working directory (using get_current_dir()), which is
typically the build directory, before running the tests. That test
directory is automatically recreated next time the test suite is run again,
to ensure the 9pfs 'local' tests always run consistently on a clean test
directory. The test directory is used by the 'local' driver as root of its
export path. So it will add/read/write/delete real files and directories
inside that test directory.
v3->v4:
* Added qos_printf() and qos_printf_literal() (NEW patch 3).
* Use qos_printf() and qos_printf_literal() instead of printf() for not
breaking TAP output (patch 4, 6, 7).
* Added private function regex_replace() to simplify and deduplicate code
(patch 9).
* RegEx pattern hardening in virtio_9p_assign_local_driver() to avoid
potential issues with future changes (patch 9).
* Updated commit log comments.
v2->v3:
* concat_path() is now just a wrapper for g_build_filename() (patch 8).
* Dropped function strpr(), using g_strdup_printf() instead (patch 8, 9).
* Fixed incorrect size for array allocation in split() function
(patch 11).
v1->v2:
* The libqos debugging features are now turned on by command line argument
'--verbose' instead of using environment variables (patches 4, 5, 6).
* The new 9pfs 'local' tests no longer depend on patches 1 and 2 by no
longer using a libqos multi-device approach, but rather modifying the
final QEMU command line for each test instead; see discussion of v1
for reason (patches 7 to 11).
* Use GCC_FMT_ATTR on helper function strpr() (patch 8).
* Updated commit log comments.
Christian Schoenebeck (12):
libqos/qgraph: add qemu_name to QOSGraphNode
libqos/qgraph: add qos_node_create_driver_named()
libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
libqos/qgraph: add qos_dump_graph()
tests/qtest/qos-test: dump qos graph if verbose
tests/qtest/qos-test: dump environment variables if verbose
tests/qtest/qos-test: dump QEMU command if verbose
tests/9pfs: change qtest name prefix to synth
tests/9pfs: introduce local tests
tests/9pfs: wipe local 9pfs test directory
tests/9pfs: add virtio_9p_test_path()
tests/9pfs: add local Tmkdir test
tests/qtest/libqos/qgraph.c | 110 ++++++++++++++-
tests/qtest/libqos/qgraph.h | 36 +++++
tests/qtest/libqos/qgraph_internal.h | 12 ++
tests/qtest/libqos/virtio-9p.c | 100 ++++++++++++++
tests/qtest/libqos/virtio-9p.h | 10 ++
tests/qtest/qos-test.c | 15 +-
tests/qtest/virtio-9p-test.c | 197 ++++++++++++++++++++++++---
7 files changed, 455 insertions(+), 25 deletions(-)
--
2.20.1
next reply other threads:[~2020-10-08 19:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 18:49 Christian Schoenebeck [this message]
2020-10-08 18:34 ` [PATCH v4 11/12] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 08/12] tests/9pfs: change qtest name prefix to synth Christian Schoenebeck
2020-10-14 15:25 ` Christian Schoenebeck
2020-10-14 19:38 ` Greg Kurz
2020-10-15 9:16 ` Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 02/12] libqos/qgraph: add qos_node_create_driver_named() Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 07/12] tests/qtest/qos-test: dump QEMU command if verbose Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 09/12] tests/9pfs: introduce local tests Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 10/12] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 05/12] tests/qtest/qos-test: dump qos graph if verbose Christian Schoenebeck
2020-10-24 6:01 ` Thomas Huth
2020-10-24 11:34 ` Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 06/12] tests/qtest/qos-test: dump environment variables " Christian Schoenebeck
2020-10-24 5:56 ` Thomas Huth
2020-10-24 10:57 ` Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 03/12] libqos/qgraph_internal: add qos_printf() and qos_printf_literal() Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 12/12] tests/9pfs: add local Tmkdir test Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 04/12] libqos/qgraph: add qos_dump_graph() Christian Schoenebeck
2020-10-24 6:04 ` Thomas Huth
2020-10-24 11:24 ` Christian Schoenebeck
2020-10-28 5:51 ` Thomas Huth
2020-10-28 13:00 ` Eric Blake
2020-10-28 13:28 ` Christian Schoenebeck
2020-10-08 18:34 ` [PATCH v4 01/12] libqos/qgraph: add qemu_name to QOSGraphNode Christian Schoenebeck
2020-10-19 10:35 ` Christian Schoenebeck
2020-10-24 6:08 ` Thomas Huth
2020-10-24 10:39 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1602182956.git.qemu_oss@crudebyte.com \
--to=qemu_oss@crudebyte.com \
--cc=berrange@redhat.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).