From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH v3 0/7] 9pfs: fix 'Twalk' protocol violation
Date: Sun, 13 Mar 2022 10:31:03 +0100 [thread overview]
Message-ID: <cover.1647163863.git.qemu_oss@crudebyte.com> (raw)
Currently the implementation of 'Twalk' does not behave exactly as specified
by the 9p2000 protocol specification. Actual fix is patch 5; see the
description of that patch for details of what this overall fix and series is
about.
Patch 4 is a preparatory (pure) refactoring change to make patch 5 better
readable.
All the other patches are just additional test cases for guarding 'Twalk'
behaviour.
v2 -> v3:
* Use 'any_err |= err = ...' at all occurrences to make v9fs_walk() function
less error prone, which also reduces lines of code. [patch 5]
Christian Schoenebeck (7):
tests/9pfs: walk to non-existent dir
tests/9pfs: Twalk with nwname=0
tests/9pfs: compare QIDs in fs_walk_none() test
9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk()
9pfs: fix 'Twalk' to only send error if no component walked
tests/9pfs: guard recent 'Twalk' behaviour fix
tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent
hw/9pfs/9p.c | 57 ++++++-----
tests/qtest/virtio-9p-test.c | 191 ++++++++++++++++++++++++++++++++++-
2 files changed, 221 insertions(+), 27 deletions(-)
--
2.30.2
next reply other threads:[~2022-03-13 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 9:31 Christian Schoenebeck [this message]
2022-03-13 9:28 ` [PATCH v3 1/7] tests/9pfs: walk to non-existent dir Christian Schoenebeck
2022-03-13 9:28 ` [PATCH v3 2/7] tests/9pfs: Twalk with nwname=0 Christian Schoenebeck
2022-03-13 9:28 ` [PATCH v3 3/7] tests/9pfs: compare QIDs in fs_walk_none() test Christian Schoenebeck
2022-03-13 9:28 ` [PATCH v3 4/7] 9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk() Christian Schoenebeck
2022-03-13 9:28 ` [PATCH v3 5/7] 9pfs: fix 'Twalk' to only send error if no component walked Christian Schoenebeck
2022-03-13 9:28 ` [PATCH v3 6/7] tests/9pfs: guard recent 'Twalk' behaviour fix Christian Schoenebeck
2022-03-13 9:28 ` [PATCH v3 7/7] tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent Christian Schoenebeck
2022-03-13 10:27 ` Christian Schoenebeck
2022-03-13 12:05 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1647163863.git.qemu_oss@crudebyte.com \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).