qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hyman Huang <yong.huang@smartx.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Hyman Huang <yong.huang@smartx.com>
Subject: [RFC 0/2] vhost-user-test: Add negotiated features check
Date: Sun, 12 Nov 2023 21:03:18 +0800	[thread overview]
Message-ID: <cover.1699793550.git.yong.huang@smartx.com> (raw)

The patchset "Fix the virtio features negotiation flaw" fix a
vhost-user negotiation flaw:
c9bdc449f9 vhost-user: Fix the virtio features negotiation flaw
bebcac052a vhost-user: Refactor the chr_closed_bh
937b7d96e4 vhost-user: Refactor vhost acked features saving

While the test case remain unmerged, the detail reference:
https://lore.kernel.org/qemu-devel/cover.1667232396.git.huangy81@chinatelecom.cn/

Since Michael pointed out that the info virtio makes sense to query
the negotiation feature, this patchset uses the x-query-virtio-status
to retrieve the features instead of exporting netdev capabilities and
information as we did in the previous patchset to aid in confirming
the negotiation's validity.

To do that, we first introduce an "show-bits" argument for
x-query-virtio-status such that the feature bits can be used
directly, and then implement the test case for negotiated features
check. As we post, the code is divided into two patches.

Please review, thanks,
Yong

Hyman Huang (2):
  qapi/virtio: introduce the "show-bits" argument for
    x-query-virtio-status
  vhost-user-test: Add negotiated features check

 hw/virtio/virtio-hmp-cmds.c   |   2 +-
 hw/virtio/virtio-qmp.c        |  21 ++++++-
 qapi/virtio.json              |  49 ++++++++++++++++-
 tests/qtest/vhost-user-test.c | 100 ++++++++++++++++++++++++++++++++++
 4 files changed, 167 insertions(+), 5 deletions(-)

-- 
2.39.1



             reply	other threads:[~2023-11-12 13:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12 13:03 Hyman Huang [this message]
2023-11-12 13:03 ` [RFC 1/2] qapi/virtio: introduce the "show-bits" argument for x-query-virtio-status Hyman Huang
2023-11-16 14:44   ` Markus Armbruster
2023-11-17 16:12     ` Yong Huang
2023-11-21  7:58       ` Markus Armbruster
2023-11-21 10:02         ` Yong Huang
2023-12-01 10:41         ` Laurent Vivier
2023-12-01 15:21           ` Markus Armbruster
2023-12-01 15:37             ` Laurent Vivier
2023-12-06  7:35               ` Markus Armbruster
2023-12-09  5:03               ` Yong Huang
2023-11-12 13:03 ` [RFC 2/2] vhost-user-test: Add negotiated features check Hyman Huang
2023-11-16  1:01 ` [RFC 0/2] " Yong Huang
2023-11-17 10:29   ` Michael S. Tsirkin
2023-11-17 16:26     ` Yong Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1699793550.git.yong.huang@smartx.com \
    --to=yong.huang@smartx.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).