From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D02C63777 for ; Mon, 30 Nov 2020 21:58:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 930262084C for ; Mon, 30 Nov 2020 21:58:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dme-org.20150623.gappssmtp.com header.i=@dme-org.20150623.gappssmtp.com header.b="JNx2V3cJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 930262084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dme.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjrBU-00028U-PN for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 16:58:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjrAd-0001h0-JA for qemu-devel@nongnu.org; Mon, 30 Nov 2020 16:57:19 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:41116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjrAa-0003sM-IX for qemu-devel@nongnu.org; Mon, 30 Nov 2020 16:57:19 -0500 Received: by mail-wr1-x443.google.com with SMTP id 23so18366341wrc.8 for ; Mon, 30 Nov 2020 13:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:cc:subject:in-reply-to:references:from:date:message-id :mime-version; bh=nTM2mj0qOopm26s4brKZwzKdnKbg9EHFY2HIPiFF3N0=; b=JNx2V3cJwk6Vt6ifDyaHe3gPb5wyXGUlOkneSAo0xdBVVm2dCDbfUPdGX+fgc26VkG 4N/84JnzD81PTFAgV9/otsbaxJSCVjaqnvwG64E/vfcqfoITRVSRW8D0hJq64XCULZG/ l2XUk6bqAoGJfsbWCp+ZOq1Kg3089oXJgCf6HpHEutXZo9T9Hz2M6VJ2P+Bzs1Ibt3h8 vURgK2W1UiyM7rYC6fyRr01qJPsicfrP8twEBdQWfKfNvjm7NblpJ8HFkrvpInEMUDew gb662DGhoWOxY3gM9n1VV0xYb46f/ZFWksWtIKaFrxVhoZKrubckpVVQIQbEc5qn9RQe vtdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date :message-id:mime-version; bh=nTM2mj0qOopm26s4brKZwzKdnKbg9EHFY2HIPiFF3N0=; b=mY7Kc6fimdmZYR5W6QjdYCfpDf6Zkz4FwRaB8Ld9lWMadcYJSB0peiSPyU6yjWTMnp nmX9IjOr4kiQEZq33p5BaniF14sNf/tEhWf5/R4XDJ+HLnAryr+h4jKIqSBpTsBOnUkg 0MWi1qmM7yuJQY1HsUHHOTp8jzBORHkfiFSMgK0S/CeTOhgRlcTW/ivlbbX6hL5ZkwLh i3H1ZSbkRugIhzSfmpdXdyTbu9M1ahBlSzQC9OwsDd3KcEJ/RAYl9djroIsl1kUplsIw xQqcTvYAjecx2ogUxHkByPTtjdvGtvkX0UYJGGfrR0gDj9OGxGfCTDSeGYyX79bMDaoJ 4fXg== X-Gm-Message-State: AOAM533AegAiu55yPcbQp8GCkpNbBOI3zs17c6T2kFiB0d6RPrngtepR VPl0VcfShVJz/SKPY2buhpa/Ug== X-Google-Smtp-Source: ABdhPJxd14kQMww9GzD2jCoJgiiev9kE2hyL9J5nL1zt/L6iJ5vRD0xMZp2md/DRTPHZoLbUDqp2GA== X-Received: by 2002:a5d:6783:: with SMTP id v3mr30598819wru.45.1606773434135; Mon, 30 Nov 2020 13:57:14 -0800 (PST) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [2001:8b0:bb71:7140:64::1]) by smtp.gmail.com with ESMTPSA id p4sm30224211wrm.51.2020.11.30.13.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 13:57:13 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 307de7b6; Mon, 30 Nov 2020 21:57:12 +0000 (UTC) To: John Snow , qemu-devel@nongnu.org, qemu-trivial@nongnu.org Subject: Re: [PATCH] qmp-shell: Sort by key when pretty-printing In-Reply-To: <27cc8383-89e1-5c5f-d8cf-7463810c1fd2@redhat.com> References: <20201013141414.18398-1-david.edmondson@oracle.com> <27cc8383-89e1-5c5f-d8cf-7463810c1fd2@redhat.com> X-HGTTG: zarquon From: David Edmondson Date: Mon, 30 Nov 2020 21:57:12 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: neutral client-ip=2a00:1450:4864:20::443; envelope-from=dme@dme.org; helo=mail-wr1-x443.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Monday, 2020-11-30 at 15:56:51 -05, John Snow wrote: > On 10/13/20 10:14 AM, David Edmondson wrote: >> If the user selects pretty-printing (-p) the contents of any >> dictionaries in the output are sorted by key. >> >> Signed-off-by: David Edmondson >> --- >> scripts/qmp/qmp-shell | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell >> index c5eef06f3f..b4d06096ab 100755 >> --- a/scripts/qmp/qmp-shell >> +++ b/scripts/qmp/qmp-shell >> @@ -260,7 +260,7 @@ class QMPShell(qmp.QEMUMonitorProtocol): >> indent = None >> if self._pretty: >> indent = 4 >> - jsobj = json.dumps(qmp, indent=indent) >> + jsobj = json.dumps(qmp, indent=indent, sort_keys=self._pretty) >> print(str(jsobj)) >> >> def _execute_cmd(self, cmdline): >> > > Hi, out of curiosity, what does this help you accomplish? When dumping a dictionary with many values, visually finding a specific one that is of interest is much quicker if they are sorted. Nothing more than that. > I've recently been overhauling a LOT of the Python utilities we have, so > I'm interested in hearing about how people use these tools and what > they'd like them to do. > > --js dme. -- I can't explain, you would not understand. This is not how I am.