* [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
@ 2020-01-15 11:37 Thomas Huth
2020-01-15 11:46 ` Laurent Vivier
2020-01-15 13:10 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2020-01-15 11:37 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Philippe Mathieu-Daude, Michael S. Tsirkin
The i8042 device is part of the chipset of a machine, so it should
be selected by the machines or chipsets (e.g. SuperIO chipsets),
and not be enabled by default.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/input/Kconfig | 1 -
hw/isa/Kconfig | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/input/Kconfig b/hw/input/Kconfig
index 287f08887b..a2f25725be 100644
--- a/hw/input/Kconfig
+++ b/hw/input/Kconfig
@@ -7,7 +7,6 @@ config LM832X
config PCKBD
bool
- default y
select PS2
depends on ISA_BUS
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 8a38813cc1..c7f07854f7 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -16,6 +16,7 @@ config I82378
config ISA_SUPERIO
bool
select ISA_BUS
+ select PCKBD
config PC87312
bool
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
2020-01-15 11:37 [PATCH] hw/input: Do not enable CONFIG_PCKBD by default Thomas Huth
@ 2020-01-15 11:46 ` Laurent Vivier
2020-01-15 14:45 ` Philippe Mathieu-Daudé
2020-01-15 13:10 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Vivier @ 2020-01-15 11:46 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Philippe Mathieu-Daude, Michael S. Tsirkin
Le 15/01/2020 à 12:37, Thomas Huth a écrit :
> The i8042 device is part of the chipset of a machine, so it should
> be selected by the machines or chipsets (e.g. SuperIO chipsets),
> and not be enabled by default.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/input/Kconfig | 1 -
> hw/isa/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index 287f08887b..a2f25725be 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -7,7 +7,6 @@ config LM832X
>
> config PCKBD
> bool
> - default y
> select PS2
> depends on ISA_BUS
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 8a38813cc1..c7f07854f7 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -16,6 +16,7 @@ config I82378
> config ISA_SUPERIO
> bool
> select ISA_BUS
> + select PCKBD
>
> config PC87312
> bool
>
It is also used by R4K but the Kconfig already includes it, so:
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
2020-01-15 11:37 [PATCH] hw/input: Do not enable CONFIG_PCKBD by default Thomas Huth
2020-01-15 11:46 ` Laurent Vivier
@ 2020-01-15 13:10 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-01-15 13:10 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: qemu-trivial, Philippe Mathieu-Daude, Michael S. Tsirkin
On 15/01/20 12:37, Thomas Huth wrote:
> The i8042 device is part of the chipset of a machine, so it should
> be selected by the machines or chipsets (e.g. SuperIO chipsets),
> and not be enabled by default.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/input/Kconfig | 1 -
> hw/isa/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index 287f08887b..a2f25725be 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -7,7 +7,6 @@ config LM832X
>
> config PCKBD
> bool
> - default y
> select PS2
> depends on ISA_BUS
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 8a38813cc1..c7f07854f7 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -16,6 +16,7 @@ config I82378
> config ISA_SUPERIO
> bool
> select ISA_BUS
> + select PCKBD
>
> config PC87312
> bool
>
Since you CCed qemu-trivial,
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
2020-01-15 11:46 ` Laurent Vivier
@ 2020-01-15 14:45 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-15 14:45 UTC (permalink / raw)
To: Laurent Vivier, Thomas Huth, qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Michael S. Tsirkin
On 1/15/20 12:46 PM, Laurent Vivier wrote:
> Le 15/01/2020 à 12:37, Thomas Huth a écrit :
>> The i8042 device is part of the chipset of a machine, so it should
>> be selected by the machines or chipsets (e.g. SuperIO chipsets),
>> and not be enabled by default.
The sentence "The i8042 device is part of the chipset of a machine"
sounds odd to me.
Maybe simply use "The i8042 PS/2 Controller should not be enabled by
default. It has to be selected by machines or chipsets (e.g. SuperIO
chipsets)."
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> hw/input/Kconfig | 1 -
>> hw/isa/Kconfig | 1 +
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
>> index 287f08887b..a2f25725be 100644
>> --- a/hw/input/Kconfig
>> +++ b/hw/input/Kconfig
>> @@ -7,7 +7,6 @@ config LM832X
>>
>> config PCKBD
>> bool
>> - default y
>> select PS2
>> depends on ISA_BUS
>>
>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>> index 8a38813cc1..c7f07854f7 100644
>> --- a/hw/isa/Kconfig
>> +++ b/hw/isa/Kconfig
>> @@ -16,6 +16,7 @@ config I82378
>> config ISA_SUPERIO
>> bool
>> select ISA_BUS
>> + select PCKBD
>>
>> config PC87312
>> bool
>>
>
> It is also used by R4K but the Kconfig already includes it, so:
I believe R4K should 'select ISA_SUPERIO' but we don't have specs and
this machine is deprecated, so I didn't bother improving it.
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-15 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 11:37 [PATCH] hw/input: Do not enable CONFIG_PCKBD by default Thomas Huth
2020-01-15 11:46 ` Laurent Vivier
2020-01-15 14:45 ` Philippe Mathieu-Daudé
2020-01-15 13:10 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).