From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] migration: Drop unused VMSTATE_FLOAT64 support
Date: Sun, 7 Feb 2021 18:10:36 +0100 [thread overview]
Message-ID: <d258bc62-1a17-aeed-13ac-b61297e01a04@amsat.org> (raw)
In-Reply-To: <20201022120830.5938-1-peter.maydell@linaro.org>
On 10/22/20 2:08 PM, Peter Maydell wrote:
> Commit ef96e3ae9698d6 in January 2019 removed the last user of the
> VMSTATE_FLOAT64* macros. These were used by targets which defined
> their floating point register file as an array of 'float64'.
Similar candidate: VMSTATE_CPUDOUBLE_ARRAY()
> We used to try to maintain a stricter distinction between
> 'float64' (a type for holding an integer representing an IEEE float)
> and 'uint64_t', including having a debug option for 'float64' being
> a struct and supposedly mandatory macros for converting between
> float64 and uint64_t. We no longer think that's a usefully
> strong distinction to draw and we allow ourselves to freely
> assume that float64 really is just a 64-bit integer type, so
> for new targets we would simply recommend use of the uint64_t type
> for a floating point register file. The float64 type remains
> as a useful way of documenting in the type signature of helper
> functions and the like that they expect to receive an IEEE float
> from the TCG generated code rather than an arbitrary integer.
>
> Since the VMSTATE_FLOAT64* macros have no remaining users and
> we don't recommend new code uses them, delete them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/migration/vmstate.h | 13 -------------
> migration/vmstate-types.c | 26 --------------------------
> 2 files changed, 39 deletions(-)
next prev parent reply other threads:[~2021-02-07 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 12:08 [PATCH] migration: Drop unused VMSTATE_FLOAT64 support Peter Maydell
2020-10-26 11:53 ` Dr. David Alan Gilbert
2020-10-26 11:57 ` Dr. David Alan Gilbert
2021-02-07 17:10 ` Philippe Mathieu-Daudé [this message]
2021-02-07 19:43 ` Peter Maydell
2021-02-08 9:31 ` Philippe Mathieu-Daudé
2021-02-08 10:00 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d258bc62-1a17-aeed-13ac-b61297e01a04@amsat.org \
--to=f4bug@amsat.org \
--cc=dgilbert@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).