From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57314C48BE5 for ; Mon, 21 Jun 2021 09:11:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E08D761002 for ; Mon, 21 Jun 2021 09:11:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E08D761002 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvFxY-0004t1-29 for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 05:11:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvFwN-0003sY-M1 for qemu-devel@nongnu.org; Mon, 21 Jun 2021 05:09:59 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:52788 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvFwL-0000UZ-RP for qemu-devel@nongnu.org; Mon, 21 Jun 2021 05:09:59 -0400 Received: from host86-132-109-72.range86-132.btcentralplus.com ([86.132.109.72] helo=[192.168.1.65]) by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lvFw4-0008mU-As; Mon, 21 Jun 2021 10:09:44 +0100 To: Richard Henderson , qemu-devel@nongnu.org References: <20210621013439.1791385-1-richard.henderson@linaro.org> <20210621013439.1791385-24-richard.henderson@linaro.org> From: Mark Cave-Ayland Message-ID: Date: Mon, 21 Jun 2021 10:09:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210621013439.1791385-24-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 86.132.109.72 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 23/26] target/sparc: Use translator_use_goto_tb X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21/06/2021 02:34, Richard Henderson wrote: > Cc: Mark Cave-Ayland > Signed-off-by: Richard Henderson > --- > target/sparc/translate.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a/target/sparc/translate.c b/target/sparc/translate.c > index 4bfa3179f8..fb0c242606 100644 > --- a/target/sparc/translate.c > +++ b/target/sparc/translate.c > @@ -339,23 +339,14 @@ static inline TCGv gen_dest_gpr(DisasContext *dc, int reg) > } > } > > -static inline bool use_goto_tb(DisasContext *s, target_ulong pc, > - target_ulong npc) > +static bool use_goto_tb(DisasContext *s, target_ulong pc, target_ulong npc) > { > - if (unlikely(s->base.singlestep_enabled || singlestep)) { > - return false; > - } > - > -#ifndef CONFIG_USER_ONLY > - return (pc & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK) && > - (npc & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK); > -#else > - return true; > -#endif > + return translator_use_goto_tb(&s->base, pc) && > + translator_use_goto_tb(&s->base, npc); > } > > -static inline void gen_goto_tb(DisasContext *s, int tb_num, > - target_ulong pc, target_ulong npc) > +static void gen_goto_tb(DisasContext *s, int tb_num, > + target_ulong pc, target_ulong npc) > { > if (use_goto_tb(s, pc, npc)) { > /* jump to same page: we can use a direct jump */ Is it still worth keeping the unlikely() hint around the single-step check? I see it isn't included in your translator_use_goto_tb() implementation in patch 1. I'll trust that you know better than me the effect of removing the inline, so: Reviewed-by: Mark Cave-Ayland ATB, Mark.