From: Connor Kuehl <ckuehl@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, richard.henderson@linaro.org,
ehabkost@redhat.com, brijesh.singh@amd.com,
thomas.lendacky@amd.com
Subject: Re: [PATCH 0/2] SEV firmware error list touchups
Date: Fri, 19 Feb 2021 08:46:48 -0600 [thread overview]
Message-ID: <d32f8265-c82c-b09e-87b1-18fa040ae70f@redhat.com> (raw)
In-Reply-To: <5ab9738d-b5c2-a580-47f1-9ebd289903f4@redhat.com>
On 2/18/21 9:48 AM, Philippe Mathieu-Daudé wrote:
> On 2/18/21 4:16 PM, Connor Kuehl wrote:
>> Connor Kuehl (2):
>> sev: use explicit indices for mapping firmware error codes to strings
>> sev: add missing firmware error conditions
>>
>> target/i386/sev.c | 48 ++++++++++++++++++++++++-----------------------
>> 1 file changed, 25 insertions(+), 23 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thank you! :-)
> To avoid this problem in future (new error code added on the Linux
> kernel side) would it be acceptable to add a 3rd patch as:
>
> -- >8 --
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index 0f414df02f3..e086d3198e8 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -155,9 +155,12 @@ sev_platform_ioctl(int fd, int cmd, void *data, int
> *error)
> static const char *
> fw_error_to_str(int code)
> {
> + QEMU_BUILD_BUG_ON(SEV_RET_SECURE_DATA_INVALID + 1 == SEV_RET_MAX);
> +
> if (code < 0 || code >= SEV_FW_MAX_ERROR) {
> return "unknown error";
> }
> + assert(sev_fw_errlist[code]);
>
> return sev_fw_errlist[code];
> }
> ---
>
> which triggers a build error if scripts/update-linux-headers.sh
> added another sev_ret_code entry?
>
I like this a lot. Should I send a v2 of the series with a third patch
like this or shall I wait to see if these patches get applied then send
something like this as a follow up patch?
Thank you,
Connor
next prev parent reply other threads:[~2021-02-19 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 15:16 [PATCH 0/2] SEV firmware error list touchups Connor Kuehl
2021-02-18 15:16 ` [PATCH 1/2] sev: use explicit indices for mapping firmware error codes to strings Connor Kuehl
2021-02-18 15:16 ` [PATCH 2/2] sev: add missing firmware error conditions Connor Kuehl
2021-02-18 15:48 ` [PATCH 0/2] SEV firmware error list touchups Philippe Mathieu-Daudé
2021-02-19 14:46 ` Connor Kuehl [this message]
2021-02-19 17:57 ` Philippe Mathieu-Daudé
2021-03-08 16:41 ` Connor Kuehl
2021-03-15 14:08 ` Connor Kuehl
2021-03-22 10:18 ` Philippe Mathieu-Daudé
2021-03-22 14:09 ` Connor Kuehl
2021-03-22 16:43 ` Eduardo Habkost
2021-05-11 7:36 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d32f8265-c82c-b09e-87b1-18fa040ae70f@redhat.com \
--to=ckuehl@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).