From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>
Cc: "qemu-block@nongnu.org" <qemu-block@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize
Date: Mon, 16 Sep 2019 13:13:01 -0400 [thread overview]
Message-ID: <d3b8a550-05e4-ca45-4c4f-ef34b74f09bf@redhat.com> (raw)
In-Reply-To: <91133853-23e0-90ad-bb51-29a6c18ffc92@virtuozzo.com>
On 9/16/19 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> 16.09.2019 19:32, John Snow wrote:
>>
>>
>> On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> 12.09.2019 3:16, John Snow wrote:
>>>> Like script_main, but doesn't require a single point of entry.
>>>> Replace all existing initialization sections with this drop-in replacement.
>>>>
>>>> This brings debug support to all existing script-style iotests.
>>>>
>>>> Note: supported_oses=['linux'] was omitted, as it is a default argument.
>>>
>>> But after this patch all test which didn't check os start to check linux
>>> (as it's default).. So all tests which worked on other platforms will now
>>> be skipped on these other platforms?
>>>
>>
>> def verify_platform(supported_oses=['linux']):
>> if True not in [sys.platform.startswith(x) for x in supported_oses]:
>> notrun('not suitable for this OS: %s' % sys.platform)
>>
>>
>> It was already the default. I didn't *make* it the default.
>
> Yes. But for some tests, verify_platform wasn't called before this patch at all.
> And now it is called and checks "linux". It's the change. Or what I miss?
>
I guess there are more than I thought.
(I thought it was just one, based on a discussion with Philippe.)
So, you're right: there are more tests now that will refuse to run on
non-Linux platforms.
Those tests are:
206
207
208
209
210
211
212
213
218
219
235
236
237
238
242
246
248
254
255
256
What sets these apart from the other python-based tests? Nothing in
particular? Just depends on who copied from whom that day. I don't think
there's any rhyme or reason to any of it.
I don't really have a BSD or OSX machine to test which ones should and
should not be limited, either.
Kevin, do you remember why we added these checks?
--js
next prev parent reply other threads:[~2019-09-16 17:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 0:16 [Qemu-devel] [PATCH v4 0/4] iotests: use python logging John Snow
2019-09-12 0:16 ` [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize John Snow
2019-09-16 14:56 ` Vladimir Sementsov-Ogievskiy
2019-09-16 16:32 ` John Snow
2019-09-16 16:39 ` Vladimir Sementsov-Ogievskiy
2019-09-16 17:13 ` John Snow [this message]
2019-09-17 22:29 ` John Snow
2019-09-18 10:30 ` Vladimir Sementsov-Ogievskiy
2019-09-18 16:44 ` Vladimir Sementsov-Ogievskiy
2019-09-18 17:00 ` John Snow
2019-09-18 13:05 ` Thomas Huth
2019-09-18 18:41 ` John Snow
2019-09-12 0:16 ` [Qemu-devel] [PATCH v4 2/4] iotest 258: use script_main John Snow
2019-09-17 9:36 ` Vladimir Sementsov-Ogievskiy
2019-09-12 0:16 ` [Qemu-devel] [PATCH v4 3/4] iotests: specify protocol support via initialization info John Snow
2019-09-17 9:51 ` Vladimir Sementsov-Ogievskiy
2019-09-12 0:16 ` [Qemu-devel] [PATCH v4 4/4] iotests: use python logging for iotests.log() John Snow
2019-09-17 11:35 ` Vladimir Sementsov-Ogievskiy
2019-09-17 19:46 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b8a550-05e4-ca45-4c4f-ef34b74f09bf@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).