From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, qemu-stable@nongnu.org,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2] linux-user: Fixes for zero_bss
Date: Thu, 21 Sep 2023 18:51:40 +0200 [thread overview]
Message-ID: <d47f9e78-cbac-83d1-e29d-373e4c45ceb0@linaro.org> (raw)
In-Reply-To: <20230909184559.36504-1-richard.henderson@linaro.org>
On 9/9/23 20:45, Richard Henderson wrote:
> The previous change, 2d385be6152, assumed !PAGE_VALID meant that
> the page would be unmapped by the elf image. However, since we
> reserved the entire image space via mmap, PAGE_VALID will always
> be set. Instead, assume PROT_NONE for the same condition.
>
> Furthermore, assume bss is only ever present for writable segments,
> and that there is no page overlap between PT_LOAD segments.
> Instead of an assert, return false to indicate failure.
>
> Cc: qemu-stable@nongnu.org
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1854
> Fixes: 2d385be6152 ("linux-user: Do not adjust zero_bss for host page size")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v2: Pass errp to zero_bss, so we can give a reasonable error message.
> ---
> linux-user/elfload.c | 53 +++++++++++++++++++++++++++++++++-----------
> 1 file changed, 40 insertions(+), 13 deletions(-)
To the best of my knowledge,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-09-21 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 18:45 [PATCH v2] linux-user: Fixes for zero_bss Richard Henderson
2023-09-21 14:52 ` Michael Tokarev
2023-09-21 16:51 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d47f9e78-cbac-83d1-e29d-373e4c45ceb0@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).