From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80C8BC433B4 for ; Mon, 5 Apr 2021 05:52:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B440061393 for ; Mon, 5 Apr 2021 05:52:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B440061393 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTI9t-00085P-Nt for qemu-devel@archiver.kernel.org; Mon, 05 Apr 2021 01:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTI8C-0006nW-14 for qemu-devel@nongnu.org; Mon, 05 Apr 2021 01:50:36 -0400 Received: from mail.ispras.ru ([83.149.199.84]:37326) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTI8A-0000u8-8O for qemu-devel@nongnu.org; Mon, 05 Apr 2021 01:50:35 -0400 Received: from [192.168.0.92] (unknown [62.118.151.149]) by mail.ispras.ru (Postfix) with ESMTPSA id 4A9E640755D3; Mon, 5 Apr 2021 05:50:31 +0000 (UTC) Subject: Re: [PATCH] hw/virtio: enable ioeventfd configuring for mmio To: qemu-devel@nongnu.org References: <161700379211.1135943.8859209566937991305.stgit@pasha-ThinkPad-X280> From: Pavel Dovgalyuk Message-ID: Date: Mon, 5 Apr 2021 08:50:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <161700379211.1135943.8859209566937991305.stgit@pasha-ThinkPad-X280> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, alex.bennee@linaro.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" ping On 29.03.2021 10:43, Pavel Dovgalyuk wrote: > This patch adds ioeventfd flag for virtio-mmio configuration. > It allows switching ioeventfd on and off. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/virtio/virtio-mmio.c | 11 ++++++++++- > include/hw/virtio/virtio-mmio.h | 5 +++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > index 342c918ea7..5952471b38 100644 > --- a/hw/virtio/virtio-mmio.c > +++ b/hw/virtio/virtio-mmio.c > @@ -36,7 +36,9 @@ > > static bool virtio_mmio_ioeventfd_enabled(DeviceState *d) > { > - return kvm_eventfds_enabled(); > + VirtIOMMIOProxy *proxy = VIRTIO_MMIO(d); > + > + return (proxy->flags & VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD) != 0; > } > > static int virtio_mmio_ioeventfd_assign(DeviceState *d, > @@ -720,6 +722,8 @@ static Property virtio_mmio_properties[] = { > DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, > format_transport_address, true), > DEFINE_PROP_BOOL("force-legacy", VirtIOMMIOProxy, legacy, true), > + DEFINE_PROP_BIT("ioeventfd", VirtIOMMIOProxy, flags, > + VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD_BIT, true), > DEFINE_PROP_END_OF_LIST(), > }; > > @@ -731,6 +735,11 @@ static void virtio_mmio_realizefn(DeviceState *d, Error **errp) > qbus_create_inplace(&proxy->bus, sizeof(proxy->bus), TYPE_VIRTIO_MMIO_BUS, > d, NULL); > sysbus_init_irq(sbd, &proxy->irq); > + > + if (!kvm_eventfds_enabled()) { > + proxy->flags &= ~VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD; > + } > + > if (proxy->legacy) { > memory_region_init_io(&proxy->iomem, OBJECT(d), > &virtio_legacy_mem_ops, proxy, > diff --git a/include/hw/virtio/virtio-mmio.h b/include/hw/virtio/virtio-mmio.h > index d4c4c386ab..090f7730e7 100644 > --- a/include/hw/virtio/virtio-mmio.h > +++ b/include/hw/virtio/virtio-mmio.h > @@ -49,12 +49,17 @@ typedef struct VirtIOMMIOQueue { > uint32_t used[2]; > } VirtIOMMIOQueue; > > +#define VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD_BIT 1 > +#define VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD \ > + (1 << VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD_BIT) > + > struct VirtIOMMIOProxy { > /* Generic */ > SysBusDevice parent_obj; > MemoryRegion iomem; > qemu_irq irq; > bool legacy; > + uint32_t flags; > /* Guest accessible state needing migration and reset */ > uint32_t host_features_sel; > uint32_t guest_features_sel; >