Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Willian Rampazzo <wrampazz@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	"Jiri Gaisler" <jiri@gaisler.se>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test
Date: Thu, 2 Apr 2020 00:01:13 +0200	[thread overview]
Message-ID: <d52e1d9d-f892-f760-6bca-e37689cff362@redhat.com> (raw)
In-Reply-To: <CAKJDGDbXeDrDWgxoZ=+LwPmexestnXJxqD5Mcrq9C4Aiy9x3dg@mail.gmail.com>

On 4/1/20 10:30 PM, Willian Rampazzo wrote:
> On Wed, Apr 1, 2020 at 5:21 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>   <snip>
>> Odd, with avocado-framework==76.0 I get:
>>
>> https://travis-ci.org/github/philmd/qemu/jobs/669851870#L4908
>>
>> Traceback (most recent call last):
>>     File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
>>       "__main__", mod_spec)
>>     File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
>>       exec(code, run_globals)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6zsite-packages/avocado/__main__.py",
>> line 11, in <module>
>>       sys.exit(main.run())
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/core/app.py",
>> line 91, in run
>>       return method(self.parser.config)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 291, in run
>>       success, fail = fetch_assets(test_file)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 200, in fetch_assets
>>       handler = FetchAssetHandler(test_file, klass, method)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 65, in __init__
>>       self.visit(self.tree)
>>     File "/usr/lib/python3.6/ast.py", line 253, in visit
>>       return visitor(node)
>>     File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
>>       self.visit(item)
>>     File "/usr/lib/python3.6/ast.py", line 253, in visit
>>       return visitor(node)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 139, in visit_ClassDef
>>       self.generic_visit(node)
>>     File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
>>       self.visit(item)
>>     File "/usr/lib/python3.6/ast.py", line 253, in visit
>>       return visitor(node)
>>     File
>> "/home/travis/build/philmd/qemu/build/tests/venv/lib/python3.6/site-packages/avocado/plugins/assets.py",
>> line 171, in visit_Assign
>>       self.asgmts[cur_klass][cur_method][name] = node.value.s
>> KeyError: 'launch_and_wait'
>> /home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for
>> target 'fetch-acceptance-assets' failed
>>
>> This launch_and_wait comes from:
>>
>> tests/acceptance/boot_linux.py:88:    def launch_and_wait(self):
> 
> Sorry about that. This is a known bug, see
> https://github.com/avocado-framework/avocado/issues/3661. It is fixed
> upstream and will be available in the next release of Avocado.

Thanks for the quick reply :)

I'm now using this kludge to include your bugfix:

-- >8 --

diff --git a/tests/requirements.txt b/tests/requirements.txt
index f9c84b4ba1..d625b32dbb 100644
--- a/tests/requirements.txt
+++ b/tests/requirements.txt
@@ -1,5 +1,5 @@
  # Add Python module requirements, one per line, to be installed
  # in the tests/venv Python virtual environment. For more info,
  # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
-avocado-framework==76.0
+-e 
git+https://github.com/avocado-framework/avocado.git@f9b4dc7c58a6424eb8d0ed6781a1d76ae3a5ab06#egg=avocado-framework
  pycdlib==1.9.0
---

But I'm getting another error:

https://travis-ci.org/github/philmd/qemu/builds/669898682#L1702

...
avocado.test: Asset not in cache, fetching it.
avocado.test: Fetching 
ftp://ftp.boulder.ibm.com/rs6000/firmware/7020-40p/P12H0456.IMG -> 
/home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.dp3lw27q
avocado.test: FileNotFoundError: [Errno 2] No such file or directory: 
'/home/travis/avocado/data/cache/by_location/9234e55550fdde347e2a4604c133fa2c8d9e9291/P12H0456.IMG.dp3lw27q'
Failed to fetch P12H0456.IMG.
/home/travis/build/philmd/qemu/tests/Makefile.include:910: recipe for 
target 'fetch-acceptance-assets' failed
make: *** [fetch-acceptance-assets] Error 4

I don't understand because all the other directories are created, I'm 
not sure what is missing here, any idea?

(test branch is https://github.com/philmd/qemu/commits/travis_fetch_avocado)

Thanks,

Phil.


