From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF74C433E0 for ; Fri, 22 May 2020 15:13:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA06205CB for ; Fri, 22 May 2020 15:13:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Io5PYxpI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEA06205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jc9MW-0000iH-RA for qemu-devel@archiver.kernel.org; Fri, 22 May 2020 11:13:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jc9L0-0007fr-NB for qemu-devel@nongnu.org; Fri, 22 May 2020 11:11:54 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:41951 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jc9Kz-0001MC-Bz for qemu-devel@nongnu.org; Fri, 22 May 2020 11:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590160312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DLKf/Nb8XQKXuRpwhy1Ic949V2/xhEZGsSVSdMGGkZo=; b=Io5PYxpIPb0tG4HlANW1qmfIKj5qE/CP8fcfw5pIpzpcZX8mEQe1CyimGqCXd2QdUBo2pq xrFZfLqULhrLEr0ALnmE+Sogq+3wsSZ2EMvPAYr2YFWGF/Rx9X186+me6P+dAIeBeg9gq+ WRYQPAJaHJlTBbW+mU6avgSLzg1O03A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-HLac_w5pPq2RFK_w3wIMrw-1; Fri, 22 May 2020 11:11:41 -0400 X-MC-Unique: HLac_w5pPq2RFK_w3wIMrw-1 Received: by mail-wr1-f71.google.com with SMTP id h6so3659407wrx.4 for ; Fri, 22 May 2020 08:11:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=DLKf/Nb8XQKXuRpwhy1Ic949V2/xhEZGsSVSdMGGkZo=; b=NDbM78VvqeTQu80mBbecAZoQjCL2g0AdPA6oT8g6tpplxUXuzzZwXyj02Ny67VpLvL O86OJmtX8VUKP5s6/R7ZuxhQGwmblAkw5C/2jeWQqd67EwYycZkTDDCROwUkLwyl5z/a dQWXI4eikuVDhjMxEz8ASiuigZ/OvwDVjF9fAQmpIdzoWgxNe8VHrf2dBcVD4uRBa1uh PmmG3TBLdImNoF5SECisd07uiKe2+RrIWzzIUE/6kesL3YH36DIP2ojjUbrGY/gipBDV pDfrMCNoB+80P3b7oIE1wPIi/gZysGHXfFAeOs34XA8IFsTgSFPmqV1Pvwj1OuJh6lNx 3yrQ== X-Gm-Message-State: AOAM531s67mN1dPCdfVJf4yPN+SN4yRCs/DbAheAgf6uZJNq1eSSO9c/ gFtMNawy6L0Rfv1fUzPlbF8s5f8KVow080bI6OnXtnpT/OObw9ZkgqXszMOct8mfQWUGNeV+sx3 SXcAUeBXUbDm1oF8= X-Received: by 2002:a05:6000:1244:: with SMTP id j4mr3924155wrx.189.1590160300256; Fri, 22 May 2020 08:11:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwG/+d4+DE2m94dLkPBnJ8imYmfCgj/5Y0RX9tFdihAuvwLfHw6ddoYoAxZo5Q6JLvA7ucZJw== X-Received: by 2002:a05:6000:1244:: with SMTP id j4mr3924113wrx.189.1590160299902; Fri, 22 May 2020 08:11:39 -0700 (PDT) Received: from [192.168.1.38] (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id r3sm9455854wmh.48.2020.05.22.08.11.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2020 08:11:39 -0700 (PDT) Subject: Re: [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it To: Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini References: <20200521195911.19685-1-philmd@redhat.com> <20200521195911.19685-12-philmd@redhat.com> <36db7554-dcc0-6b8c-e7b7-628c105d8fc7@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Fri, 22 May 2020 17:11:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <36db7554-dcc0-6b8c-e7b7-628c105d8fc7@linaro.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/22 11:11:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peter Maydell , Thomas Huth , qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann , Chris Wulff , Laurent Vivier , Max Filippov , Aleksandar Markovic , qemu-arm@nongnu.org, Palmer Dabbelt , Michael Walle , Alistair Francis , Aleksandar Rikalo , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/22/20 6:26 AM, Richard Henderson wrote: > On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote: >> +++ b/hw/semihosting/Kconfig >> @@ -1,3 +1,5 @@ >> >> +# default is 'n' >> config SEMIHOSTING >> - bool >> + bool >> + depends on TCG >> diff --git a/target/arm/Kconfig b/target/arm/Kconfig >> new file mode 100644 >> index 0000000000..035592dd86 >> --- /dev/null >> +++ b/target/arm/Kconfig >> @@ -0,0 +1,2 @@ >> +config SEMIHOSTING >> + default y if TCG > > Did you answer my question about replicating the TCG test? If you did, I > missed it... Shortly before posting this series: https://www.mail-archive.com/qemu-devel@nongnu.org/msg705992.html There is indeed something wrong with this patch, but I'm not seeing it. - semihosting only makes sense with TCG accelerator This is the "depends on TCG" - some targets (if built with TCG enabled) require semihosting This would be a per-target "select SEMIHOSTING if TCG" Another problem is some targets only require semihosting in system-mode; and this approach select it for both system/user modes. Paolo... help!