From: Richard Henderson <richard.henderson@linaro.org>
To: Claudio Fontana <cfontana@suse.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [RFC v1 24/38] target/arm: move aa64_va_parameter_tbi,tbid,tcma and arm_rebuild_hflags
Date: Sun, 21 Feb 2021 22:02:24 -0800 [thread overview]
Message-ID: <d7bca535-d6eb-780b-7248-d6810652c76d@linaro.org> (raw)
In-Reply-To: <20210221092449.7545-25-cfontana@suse.de>
On 2/21/21 1:24 AM, Claudio Fontana wrote:
> From: Claudio Fontana <cfontana@centriq4.arch.suse.de>
>
> they are needed for KVM too, move them out of TCG helpers.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
> target/arm/internals.h | 37 +++++
> target/arm/tcg/helper-tcg.h | 32 -----
> target/arm/cpu-common.c | 252 ++++++++++++++++++++++++++++++++++
> target/arm/tcg/helper.c | 264 +-----------------------------------
> 4 files changed, 293 insertions(+), 292 deletions(-)
>
> diff --git a/target/arm/internals.h b/target/arm/internals.h
> index 6589b63ebc..9eb5d7fd79 100644
> --- a/target/arm/internals.h
> +++ b/target/arm/internals.h
> @@ -1196,6 +1196,43 @@ static inline uint64_t useronly_maybe_clean_ptr(uint32_t desc, uint64_t ptr)
> return ptr;
> }
>
> +/*
> + * Convert a possible stage1+2 MMU index into the appropriate
> + * stage 1 MMU index
> + */
> +static inline ARMMMUIdx stage_1_mmu_idx(ARMMMUIdx mmu_idx)
> +{
> + switch (mmu_idx) {
> + case ARMMMUIdx_SE10_0:
> + return ARMMMUIdx_Stage1_SE0;
> + case ARMMMUIdx_SE10_1:
> + return ARMMMUIdx_Stage1_SE1;
> + case ARMMMUIdx_SE10_1_PAN:
> + return ARMMMUIdx_Stage1_SE1_PAN;
> + case ARMMMUIdx_E10_0:
> + return ARMMMUIdx_Stage1_E0;
> + case ARMMMUIdx_E10_1:
> + return ARMMMUIdx_Stage1_E1;
> + case ARMMMUIdx_E10_1_PAN:
> + return ARMMMUIdx_Stage1_E1_PAN;
> + default:
> + return mmu_idx;
> + }
> +}
> +
> +int aa64_va_parameter_tbi(uint64_t tcr, ARMMMUIdx mmu_idx);
> +int aa64_va_parameter_tbid(uint64_t tcr, ARMMMUIdx mmu_idx);
I can see these being needed for get-phys-addr -- and that probably answers my
arm_mmu_idx_el question earlier too.
> +uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
> + ARMMMUIdx mmu_idx);
> +uint32_t rebuild_hflags_a32(CPUARMState *env, int fp_el, ARMMMUIdx mmu_idx);
> +uint32_t rebuild_hflags_m32(CPUARMState *env, int fp_el, ARMMMUIdx mmu_idx);
However these really really shouldn't be used for !tcg. I would even wrap
CPUARMState::hflags in #ifdef CONFIG_TCG to enforce that.
I think maybe the best option is
if (tcg_enabled()) {
rebuild_hflags();
}
so that we don't spend the time on the rebuild for a regular build that has
both tcg and kvm enabled, and the symbol gets
compiled out when tcg is disabled.
r~
next prev parent reply other threads:[~2021-02-22 6:05 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210221092449.7545-1-cfontana@suse.de>
[not found] ` <20210221092449.7545-33-cfontana@suse.de>
2021-02-21 9:53 ` [RFC v1 32/38] target/arm: cpu: do not initialize TCG PMU for KVM Philippe Mathieu-Daudé
2021-02-21 13:59 ` Claudio Fontana
2021-02-22 6:11 ` Richard Henderson
[not found] ` <20210221092449.7545-35-cfontana@suse.de>
2021-02-21 9:55 ` [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG Philippe Mathieu-Daudé
2021-02-21 13:59 ` Claudio Fontana
2021-02-22 8:35 ` Claudio Fontana
2021-03-01 18:19 ` Olaf Hering
[not found] ` <87v9ak5cz0.fsf@linaro.org>
2021-02-23 9:12 ` Claudio Fontana
2021-02-23 11:01 ` Alex Bennée
2021-02-23 11:36 ` Claudio Fontana
2021-02-23 12:38 ` Claudio Fontana
2021-02-23 14:47 ` Paolo Bonzini
2021-02-22 5:35 ` [RFC v1 00/38] arm cleanup experiment for kvm-only build Richard Henderson
2021-02-22 8:43 ` Claudio Fontana
2021-02-22 11:56 ` Philippe Mathieu-Daudé
2021-02-22 16:08 ` Richard Henderson
2021-02-22 16:57 ` Alex Bennée
2021-02-23 9:17 ` Claudio Fontana
[not found] ` <20210221092449.7545-21-cfontana@suse.de>
2021-02-22 5:48 ` [RFC v1 20/38] target/arm: move arm_hcr_el2_eff to common_cpu Richard Henderson
[not found] ` <20210221092449.7545-24-cfontana@suse.de>
2021-02-22 5:52 ` [RFC v1 23/38] target/arm: move arm_mmu_idx_el to common-cpu Richard Henderson
[not found] ` <20210221092449.7545-25-cfontana@suse.de>
2021-02-22 6:02 ` Richard Henderson [this message]
2021-02-23 10:07 ` [RFC v1 24/38] target/arm: move aa64_va_parameter_tbi,tbid,tcma and arm_rebuild_hflags Claudio Fontana
2021-02-23 16:30 ` Richard Henderson
[not found] ` <20210221092449.7545-26-cfontana@suse.de>
2021-02-22 6:04 ` [RFC v1 25/38] target/arm: move fp_exception_el outside of tcg helpers Richard Henderson
[not found] ` <20210221092449.7545-27-cfontana@suse.de>
2021-02-22 6:05 ` [RFC v1 26/38] target/arm: move sve_exception_el to cpu Richard Henderson
[not found] ` <20210221092449.7545-28-cfontana@suse.de>
2021-02-22 6:06 ` [RFC v1 27/38] target/arm: move sve_zcr_len_for_el to common_cpu Richard Henderson
2021-02-25 17:28 ` Claudio Fontana
2021-02-25 20:13 ` Claudio Fontana
2021-02-26 4:01 ` Richard Henderson
[not found] ` <20210221092449.7545-29-cfontana@suse.de>
2021-02-22 6:09 ` [RFC v1 28/38] target/arm: make arm_pmu_timer_cb TCG-only, starting tcg-stub Richard Henderson
[not found] ` <20210221092449.7545-2-cfontana@suse.de>
2021-02-22 6:14 ` [RFC v1 01/38] target/arm: move translate modules to tcg/ Richard Henderson
[not found] ` <20210221092449.7545-4-cfontana@suse.de>
2021-02-22 6:16 ` [RFC v1 03/38] arm: tcg: only build under CONFIG_TCG Richard Henderson
[not found] ` <20210221092449.7545-6-cfontana@suse.de>
2021-02-22 6:21 ` [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG Richard Henderson
2021-02-22 8:31 ` Claudio Fontana
2021-02-22 15:54 ` Richard Henderson
2021-02-23 8:46 ` Claudio Fontana
[not found] ` <20210221092449.7545-9-cfontana@suse.de>
2021-02-22 6:29 ` [RFC v1 08/38] target/arm/tcg: split softmmu parts of v8_cp_reginfo and el2_cp_reginfo Richard Henderson
[not found] ` <20210221092449.7545-3-cfontana@suse.de>
2021-02-22 6:16 ` [RFC v1 02/38] target/arm: move helpers to tcg/ Richard Henderson
2021-02-22 17:20 ` Philippe Mathieu-Daudé
[not found] ` <20210221092449.7545-5-cfontana@suse.de>
[not found] ` <87eeh857xf.fsf@linaro.org>
2021-02-23 8:44 ` [RFC v1 04/38] target/arm: move psci.c into tcg/softmmu/ Claudio Fontana
[not found] ` <20210221092449.7545-7-cfontana@suse.de>
[not found] ` <87blcc57rj.fsf@linaro.org>
2021-02-23 8:55 ` [RFC v1 06/38] target/arm: split off cpu-softmmu.c Claudio Fontana
2021-02-23 9:16 ` Philippe Mathieu-Daudé
2021-02-23 9:35 ` Claudio Fontana
2021-02-23 18:18 ` softmmu vs sysemu [Was: Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c] Claudio Fontana
2021-02-23 18:51 ` Richard Henderson
2021-02-23 23:43 ` Philippe Mathieu-Daudé
2021-02-24 0:06 ` Richard Henderson
2021-02-24 9:20 ` Paolo Bonzini
2021-02-24 9:30 ` Claudio Fontana
2021-02-24 10:00 ` Paolo Bonzini
[not found] ` <875z2k53mn.fsf@linaro.org>
2021-02-23 9:18 ` [RFC v1 00/38] arm cleanup experiment for kvm-only build Philippe Mathieu-Daudé
2021-03-01 11:52 ` Claudio Fontana
2021-03-01 16:23 ` Alex Bennée
2021-03-03 17:57 ` Claudio Fontana
2021-03-03 18:09 ` Peter Maydell
2021-03-03 18:17 ` Claudio Fontana
2021-03-03 18:20 ` Claudio Fontana
2021-03-03 18:30 ` Philippe Mathieu-Daudé
2021-03-03 18:39 ` Richard Henderson
2021-03-03 18:45 ` Claudio Fontana
2021-03-03 18:54 ` Richard Henderson
2021-03-04 16:39 ` Philippe Mathieu-Daudé
2021-03-04 17:19 ` Claudio Fontana
2021-03-04 17:47 ` Philippe Mathieu-Daudé
2021-03-04 19:24 ` Peter Maydell
2021-03-05 9:04 ` Claudio Fontana
2021-03-03 18:34 ` Philippe Mathieu-Daudé
2021-03-03 18:38 ` Claudio Fontana
2021-02-23 9:18 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7bca535-d6eb-780b-7248-d6810652c76d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cfontana@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).