qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Bin Meng <bmeng.cn@gmail.com>, Stefan Weil <sw@weilnetz.de>,
	Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] nsis: Install *.elf images
Date: Fri, 26 Mar 2021 19:40:22 +0100	[thread overview]
Message-ID: <d8569662-1c7f-dc26-130e-0c1b83c885e8@amsat.org> (raw)
In-Reply-To: <20210326062140.367861-1-bmeng.cn@gmail.com>

On 3/26/21 7:21 AM, Bin Meng wrote:
> As of today, the QEMU Windows installer does not include the
> following two RISC-V BIOS images:
> 
> - opensbi-riscv64-generic-fw_dynamic.elf
> - opensbi-riscv32-generic-fw_dynamic.elf
> 
> Update the installer script to include them.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Following this series' idea:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg794466.html
"blobs: Only install required (system emulation) files"

Maybe we can use meson + cpp with C #ifdef'ry (including
config-host.h + meson definitions) to generate qemu.nsi
with only required blobs?

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
> Based on:
> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
> 
> The above commit does not land on QEMU master. I am not sure what
> the process is, sending it here for comments.
> 
>  qemu.nsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/qemu.nsi b/qemu.nsi
> index 96c5534254..aeabe3bdbe 100644
> --- a/qemu.nsi
> +++ b/qemu.nsi
> @@ -142,6 +142,7 @@ Section "${PRODUCT}" QEMU_System_File_Section_Description
>  
>      File "${DATADIR}\*.bin"
>      File "${DATADIR}\*.dtb"
> +    File "${DATADIR}\*.elf"
>      File "${DATADIR}\*.fd"
>      File "${DATADIR}\*.img"
>      File "${DATADIR}\*.lid"
> @@ -258,6 +259,7 @@ Section "Uninstall" Uninstall_Section_Description
>      Delete "$INSTDIR\*.bin"
>      Delete "$INSTDIR\*.dll"
>      Delete "$INSTDIR\*.dtb"
> +    Delete "$INSTDIR\*.elf"
>      Delete "$INSTDIR\*.fd"
>      Delete "$INSTDIR\*.img"
>      Delete "$INSTDIR\*.lid"
> 



  reply	other threads:[~2021-03-26 18:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  6:21 Bin Meng
2021-03-26 18:40 ` Philippe Mathieu-Daudé [this message]
2021-03-30 16:15 ` Alistair Francis
2021-04-06  9:04 ` Bin Meng
2021-04-06  9:28   ` Stefan Weil
2021-04-07 12:06     ` Laurent Vivier
2021-04-07 12:13       ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8569662-1c7f-dc26-130e-0c1b83c885e8@amsat.org \
    --to=f4bug@amsat.org \
    --cc=bmeng.cn@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --subject='Re: [PATCH] nsis: Install *.elf images' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).