From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC15C43331 for ; Sat, 28 Mar 2020 16:25:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0028320716 for ; Sat, 28 Mar 2020 16:25:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0028320716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIEH9-0006Ps-1f for qemu-devel@archiver.kernel.org; Sat, 28 Mar 2020 12:25:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52387) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIEFM-0005B8-9y for qemu-devel@nongnu.org; Sat, 28 Mar 2020 12:23:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIEFL-0003GL-00 for qemu-devel@nongnu.org; Sat, 28 Mar 2020 12:23:43 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:36392) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jIEFK-0003BW-Gn; Sat, 28 Mar 2020 12:23:42 -0400 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.08911659|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_system_inform|0.139685-0.000514931-0.8598; FP=0|0|0|0|0|-1|-1|-1; HT=e02c03297; MF=zhiwei_liu@c-sky.com; NM=1; PH=DS; RN=9; RT=9; SR=0; TI=SMTPD_---.H6jfVbC_1585412611; Received: from 192.168.3.18(mailfrom:zhiwei_liu@c-sky.com fp:SMTPD_---.H6jfVbC_1585412611) by smtp.aliyun-inc.com(10.147.42.135); Sun, 29 Mar 2020 00:23:32 +0800 Subject: Re: [PATCH v6 55/61] target/riscv: integer extract instruction To: Richard Henderson , alistair23@gmail.com, chihmin.chao@sifive.com, palmer@dabbelt.com References: <20200317150653.9008-1-zhiwei_liu@c-sky.com> <20200317150653.9008-56-zhiwei_liu@c-sky.com> <07501722-9afa-0a47-bba5-434631335372@linaro.org> From: LIU Zhiwei Message-ID: Date: Sun, 29 Mar 2020 00:23:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <07501722-9afa-0a47-bba5-434631335372@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 121.197.200.217 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guoren@linux.alibaba.com, wenmeng_zhang@c-sky.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org, wxy194768@alibaba-inc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/3/28 11:36, Richard Henderson wrote: > On 3/17/20 8:06 AM, LIU Zhiwei wrote: >> +/* Integer Extract Instruction */ >> +static void extract_element(TCGv dest, TCGv_ptr base, >> + int ofs, int sew) >> +{ >> + switch (sew) { >> + case MO_8: >> + tcg_gen_ld8u_tl(dest, base, ofs); >> + break; >> + case MO_16: >> + tcg_gen_ld16u_tl(dest, base, ofs); >> + break; >> + default: >> + tcg_gen_ld32u_tl(dest, base, ofs); >> + break; >> +#if TARGET_LONG_BITS == 64 >> + case MO_64: >> + tcg_gen_ld_i64(dest, base, ofs); >> + break; >> +#endif >> + } >> +} > I just remembered that this doesn't handle HOST_WORDS_BIGENDIAN properly -- the > MO_64 case for TARGET_LONG_BITS == 32. > > Because we computed the offset for MO_64, not MO_32, we need > > case MO_64: > if (TARGET_LONG_BITS == 64) { > tcg_gen_ld_i64(dest, base, ofs); > break; > } > #ifdef HOST_WORDS_BIGENDIAN > ofs += 4; > #endif > /* fall through */ > case MO_32: > tcg_gen_ld32u_tl(dest, base, ofs); > break; > default: > g_assert_not_reached(); Yes, it should be. As extract_element and gather_element are very similar . I will merge them to  load_element in v7. Zhiwei > > r~