qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Shu-Chun Weng <scw@google.com>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: erroneous fd_trans_unregister call
Date: Fri, 23 Aug 2019 18:28:04 +0200	[thread overview]
Message-ID: <d969c965-8dd0-c332-1286-47a117504979@vivier.eu> (raw)
In-Reply-To: <20190819185348.221825-1-scw@google.com>

Le 19/08/2019 à 20:53, Shu-Chun Weng via Qemu-devel a écrit :
> timer_getoverrun returns the "overrun count" for the timer, which is not
> a file descriptor and thus should not call fd_trans_unregister on it.
> 
> Signed-off-by: Shu-Chun Weng <scw@google.com>
> ---
>  linux-user/syscall.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 8367cb138d..012d79f8c1 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -11846,7 +11846,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
>              timer_t htimer = g_posix_timers[timerid];
>              ret = get_errno(timer_getoverrun(htimer));
>          }
> -        fd_trans_unregister(ret);
>          return ret;
>      }
>  #endif
> 

Applied to my linux-user branch.

Thanks,
Laurent


      parent reply	other threads:[~2019-08-23 16:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 18:53 [Qemu-devel] [PATCH] linux-user: erroneous fd_trans_unregister call Shu-Chun Weng via Qemu-devel
2019-08-19 19:06 ` no-reply
2019-08-19 19:32 ` Laurent Vivier
2019-08-19 19:55 ` no-reply
2019-08-23 16:28 ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d969c965-8dd0-c332-1286-47a117504979@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=scw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).