From: Richard Henderson <email@example.com> To: "Philippe Mathieu-Daudé" <firstname.lastname@example.org>, email@example.com Cc: Paolo Bonzini <firstname.lastname@example.org> Subject: Re: [PATCH-for-6.1] exec: Remove accel/tcg/ from include paths Date: Tue, 13 Apr 2021 07:20:32 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 4/13/21 1:10 AM, Philippe Mathieu-Daudé wrote: > When TCG is enabled, the accel/tcg/ include path is added to the > project global include search list. This accel/tcg/ directory > contains a header named "internal.h" which, while intented to > be internal to accel/tcg/, is accessible by all files compiled > when TCG is enabled. This might lead to problem with other > directories using the same "internal.h" header name: > > $ git ls-files | fgrep /internal.h > accel/tcg/internal.h > include/hw/ide/internal.h > target/hexagon/internal.h > target/mips/internal.h > target/ppc/internal.h > target/s390x/internal.h > > As we don't need to expose accel/tcg/ internals to the rest of > the code base, simplify by removing it from the include search > list, and include the accel/tcg/ public headers relative to the > project root search path (which is already in the generic include > search path). > > Signed-off-by: Philippe Mathieu-Daudé<email@example.com> > --- Queued on tcg-next, thanks. r~
prev parent reply other threads:[~2021-04-13 14:21 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 8:10 Philippe Mathieu-Daudé 2021-04-13 8:17 ` Claudio Fontana 2021-04-13 14:20 ` Richard Henderson [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH-for-6.1] exec: Remove accel/tcg/ from include paths' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).