From: John Snow <jsnow@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] os: deprecate the -enable-fips option and QEMU's FIPS enforcement
Date: Thu, 22 Oct 2020 10:04:20 -0400 [thread overview]
Message-ID: <d9d4e758-c660-9860-9fac-ecc43e52b80f@redhat.com> (raw)
In-Reply-To: <20201021101743.GI412988@redhat.com>
On 10/21/20 6:17 AM, Daniel P. Berrangé wrote:
> Claiming QEMU is FIPS compliant without using libgcrypt is a
> bit of joke since we don't do any self-tests of ciphers, hence
> this deprecation notice is warning people that libgcrypt is
> going to be mandatory if you care about FIPS.
>
FWIW this is my main problem with this flag: we read the value in procfs
and then use this to change precisely one behavior for one of our
components. It doesn't really ... do what the name might imply it does.
Leaving that business to the crypto libraries is indeed the correct
thing to do.
So:
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2020-10-22 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 16:22 [PATCH] os: deprecate the -enable-fips option and QEMU's FIPS enforcement Daniel P. Berrangé
2020-10-20 17:22 ` Paolo Bonzini
2020-10-21 8:38 ` Daniel P. Berrangé
2020-10-21 9:51 ` Paolo Bonzini
2020-10-21 10:17 ` Daniel P. Berrangé
2020-10-21 11:47 ` Paolo Bonzini
2020-10-22 14:04 ` John Snow [this message]
2020-10-21 5:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d4e758-c660-9860-9fac-ecc43e52b80f@redhat.com \
--to=jsnow@redhat.com \
--cc=berrange@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).