From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F03C5DF61 for ; Thu, 7 Nov 2019 11:58:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6769C2166E for ; Thu, 7 Nov 2019 11:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6769C2166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSgQf-00044x-Lb for qemu-devel@archiver.kernel.org; Thu, 07 Nov 2019 06:58:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53245) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSgQ3-0003aD-AK for qemu-devel@nongnu.org; Thu, 07 Nov 2019 06:57:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSgQ2-0001F5-3C for qemu-devel@nongnu.org; Thu, 07 Nov 2019 06:57:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:48724 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSgPy-000178-2k; Thu, 07 Nov 2019 06:57:38 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E310182D411826A41F90; Thu, 7 Nov 2019 19:57:31 +0800 (CST) Received: from [127.0.0.1] (10.133.216.73) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Thu, 7 Nov 2019 19:57:23 +0800 Subject: Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall To: "Michael S. Tsirkin" References: <20191105091056.9541-1-guoheyi@huawei.com> <20191105091056.9541-12-guoheyi@huawei.com> <20191106185524.0fe51c50.cohuck@redhat.com> <4dbcbd18-0e6c-f985-c36d-96df65331d11@huawei.com> <20191107035624-mutt-send-email-mst@kernel.org> From: Guoheyi Message-ID: Date: Thu, 7 Nov 2019 19:57:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20191107035624-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.216.73] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , Marc Zyngier , Cornelia Huck , qemu-devel@nongnu.org, qemu-arm@nongnu.org, James Morse , Paolo Bonzini , wanghaibin.wang@huawei.com, Dave Martin Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019/11/7 16:57, Michael S. Tsirkin wrote: > On Thu, Nov 07, 2019 at 09:44:36AM +0800, Guoheyi wrote: >> >> On 2019/11/7 1:55, Cornelia Huck wrote: >>> On Tue, 5 Nov 2019 17:10:53 +0800 >>> Heyi Guo wrote: >>> >>>> To keep backward compatibility, we add new KVM capability >>>> "KVM_CAP_FORWARD_HYPERCALL" to probe whether KVM supports forwarding >>>> hypercall to userspace. >>>> >>>> The capability should be enabled explicitly, for we don't want user >>>> space application to deal with unexpected hypercall exits. After >>>> enabling this cap, all HVC calls unhandled by kvm will be forwarded to >>>> user space. >>>> >>>> Signed-off-by: Heyi Guo >>>> Cc: Peter Maydell >>>> Cc: "Michael S. Tsirkin" >>>> Cc: Cornelia Huck >>>> Cc: Paolo Bonzini >>>> Cc: Dave Martin >>>> Cc: Marc Zyngier >>>> Cc: Mark Rutland >>>> Cc: James Morse >>>> --- >>>> linux-headers/linux/kvm.h | 1 + >>>> target/arm/sdei.c | 16 ++++++++++++++++ >>>> target/arm/sdei.h | 2 ++ >>>> 3 files changed, 19 insertions(+) >>>> >>>> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h >>>> index 3d9b18f7f8..36c9b3859f 100644 >>>> --- a/linux-headers/linux/kvm.h >>>> +++ b/linux-headers/linux/kvm.h >>>> @@ -1000,6 +1000,7 @@ struct kvm_ppc_resize_hpt { >>>> #define KVM_CAP_PMU_EVENT_FILTER 173 >>>> #define KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 174 >>>> #define KVM_CAP_HYPERV_DIRECT_TLBFLUSH 175 >>>> +#define KVM_CAP_FORWARD_HYPERCALL 176 >>>> #ifdef KVM_CAP_IRQ_ROUTING >>> Is this cap upstream already? I would have thought your header sync >>> would have brought it in, then. (Saying this, that header sync looks >>> awfully small.) >>> >>> If it is not upstream yet, please split off this hunk into a separate >>> patch -- it's a bit annoying, but makes life easier for merging. >> No, it is not upstream yet. The whole framework and interfaces between KVM >> and qemu are still under discussion. I'll keep in mind of this when moving >> forward to next steps... >> >> Thanks, >> HG > It's best to add it in some other place meanwhile. Do you mean to split this patch from the whole patch set and send it separately? Sorry I'm not clear about maintainers' work and may bring you some trouble... Thanks, HG > Then we can drop it when it's in an upstream header. > > >>> >>> . >>> > . >