From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH v3 04/11] Acceptance Tests: move useful ssh methods to base class
Date: Mon, 19 Apr 2021 17:22:32 +0200 [thread overview]
Message-ID: <da84ade4-6d66-7728-7edd-3d128aa43f0f@amsat.org> (raw)
In-Reply-To: <20210412044644.55083-5-crosa@redhat.com>
On 4/12/21 6:46 AM, Cleber Rosa wrote:
> Both the virtiofs submounts and the linux ssh mips malta tests
> contains useful methods related to ssh that deserve to be made
> available to other tests. Let's move them to an auxiliary, mix-in
> class that will be used on the base LinuxTest class.
>
> The method that helps with setting up an ssh connection will now
> support both key and password based authentication, defaulting to key
> based.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 48 ++++++++++++++++++++++-
> tests/acceptance/linux_ssh_mips_malta.py | 40 ++-----------------
> tests/acceptance/virtiofs_submounts.py | 37 -----------------
> 3 files changed, 50 insertions(+), 75 deletions(-)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> index 83b1741ec85..67f75f66e56 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
Don't we need to update the copyright in this file?
I ask because I'm never sure how that works.... In my patches
when I move code which is in a copyrighted file, I add the same
copyright lines to the copied file.
> @@ -20,6 +20,7 @@
> from avocado.utils import cloudinit
> from avocado.utils import datadrainer
> from avocado.utils import network
> +from avocado.utils import ssh
> from avocado.utils import vmimage
> from avocado.utils.path import find_command
>
> @@ -43,6 +44,8 @@
> from qemu.accel import kvm_available
> from qemu.accel import tcg_available
> from qemu.machine import QEMUMachine
> +from qemu.utils import get_info_usernet_hostfwd_port
> +
>
> def is_readable_executable_file(path):
> return os.path.isfile(path) and os.access(path, os.R_OK | os.X_OK)
> @@ -253,7 +256,50 @@ def fetch_asset(self, name,
> cancel_on_missing=cancel_on_missing)
>
>
> -class LinuxTest(Test):
> +class LinuxSSHMixIn:
> + """Contains utility methods for interacting with a guest via SSH."""
> +
> + def ssh_connect(self, username, credential, credential_is_key=True):
> + self.ssh_logger = logging.getLogger('ssh')
> + res = self.vm.command('human-monitor-command',
> + command_line='info usernet')
> + port = get_info_usernet_hostfwd_port(res)
> + self.assertIsNotNone(port)
> + self.assertGreater(port, 0)
> + self.log.debug('sshd listening on port: %d', port)
> + if credential_is_key:
> + self.ssh_session = ssh.Session('127.0.0.1', port=port,
> + user=username, key=credential)
> + else:
> + self.ssh_session = ssh.Session('127.0.0.1', port=port,
> + user=username, password=credential)
> + for i in range(10):
> + try:
> + self.ssh_session.connect()
> + return
> + except:
> + time.sleep(4)
> + pass
> + self.fail('ssh connection timeout')
> +
> + def ssh_command(self, command):
> + self.ssh_logger.info(command)
> + result = self.ssh_session.cmd(command)
> + stdout_lines = [line.rstrip() for line
> + in result.stdout_text.splitlines()]
> + for line in stdout_lines:
> + self.ssh_logger.info(line)
> + stderr_lines = [line.rstrip() for line
> + in result.stderr_text.splitlines()]
> + for line in stderr_lines:
> + self.ssh_logger.warning(line)
> +
> + self.assertEqual(result.exit_status, 0,
> + f'Guest command failed: {command}')
> + return stdout_lines, stderr_lines
> +
> +
> +class LinuxTest(Test, LinuxSSHMixIn):
> """Facilitates having a cloud-image Linux based available.
>
> For tests that indend to interact with guests, this is a better choice
> diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py
> index 052008f02d4..61c9079d047 100644
> --- a/tests/acceptance/linux_ssh_mips_malta.py
> +++ b/tests/acceptance/linux_ssh_mips_malta.py
> @@ -12,16 +12,14 @@
> import time
>
> from avocado import skipUnless
> -from avocado_qemu import Test
> +from avocado_qemu import Test, LinuxSSHMixIn
> from avocado_qemu import wait_for_console_pattern
> from avocado.utils import process
> from avocado.utils import archive
> from avocado.utils import ssh
>
> -from qemu.utils import get_info_usernet_hostfwd_port
>
> -
> -class LinuxSSH(Test):
> +class LinuxSSH(Test, LinuxSSHMixIn):
>
> timeout = 150 # Not for 'configure --enable-debug --enable-debug-tcg'
>
> @@ -72,41 +70,9 @@ def get_kernel_info(self, endianess, wordsize):
> def setUp(self):
> super(LinuxSSH, self).setUp()
>
> - def ssh_connect(self, username, password):
> - self.ssh_logger = logging.getLogger('ssh')
> - res = self.vm.command('human-monitor-command',
> - command_line='info usernet')
> - port = get_info_usernet_hostfwd_port(res)
> - if not port:
> - self.cancel("Failed to retrieve SSH port")
> - self.log.debug("sshd listening on port:" + port)
> - self.ssh_session = ssh.Session(self.VM_IP, port=int(port),
> - user=username, password=password)
> - for i in range(10):
> - try:
> - self.ssh_session.connect()
> - return
> - except:
> - time.sleep(4)
> - pass
> - self.fail("ssh connection timeout")
> -
> def ssh_disconnect_vm(self):
> self.ssh_session.quit()
>
> - def ssh_command(self, command, is_root=True):
> - self.ssh_logger.info(command)
> - result = self.ssh_session.cmd(command)
> - stdout_lines = [line.rstrip() for line
> - in result.stdout_text.splitlines()]
> - for line in stdout_lines:
> - self.ssh_logger.info(line)
> - stderr_lines = [line.rstrip() for line
> - in result.stderr_text.splitlines()]
> - for line in stderr_lines:
> - self.ssh_logger.warning(line)
> - return stdout_lines, stderr_lines
> -
> def boot_debian_wheezy_image_and_ssh_login(self, endianess, kernel_path):
> image_url, image_hash = self.get_image_info(endianess)
> image_path = self.fetch_asset(image_url, asset_hash=image_hash)
> @@ -127,7 +93,7 @@ def boot_debian_wheezy_image_and_ssh_login(self, endianess, kernel_path):
> wait_for_console_pattern(self, console_pattern, 'Oops')
> self.log.info('sshd ready')
>
> - self.ssh_connect('root', 'root')
> + self.ssh_connect('root', 'root', False)
>
> def shutdown_via_ssh(self):
> self.ssh_command('poweroff')
next prev parent reply other threads:[~2021-04-19 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 4:46 [PATCH v3 00/11] Acceptance Test: introduce base class for Linux based tests Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 01/11] tests/acceptance/virtiofs_submounts.py: add missing accel tag Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 02/11] tests/acceptance/virtiofs_submounts.py: evaluate string not length Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 03/11] Python: add utility function for retrieving port redirection Cleber Rosa
2021-05-13 19:10 ` John Snow
2021-04-12 4:46 ` [PATCH v3 04/11] Acceptance Tests: move useful ssh methods to base class Cleber Rosa
2021-04-19 15:22 ` Philippe Mathieu-Daudé [this message]
2021-04-12 4:46 ` [PATCH v3 05/11] Acceptance Tests: add port redirection for ssh by default Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 06/11] Acceptance Tests: make username/password configurable Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 07/11] Acceptance Tests: set up SSH connection by default after boot for LinuxTest Cleber Rosa
2021-04-19 15:05 ` Auger Eric
2021-04-12 4:46 ` [PATCH v3 08/11] tests/acceptance/virtiofs_submounts.py: remove launch_vm() Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 09/11] Acceptance Tests: add basic documentation on LinuxTest base class Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 10/11] Acceptance Tests: introduce CPU hotplug test Cleber Rosa
2021-04-12 4:46 ` [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey Cleber Rosa
2021-04-12 15:08 ` Wainer dos Santos Moschetta
2021-04-12 18:59 ` Willian Rampazzo
2021-04-19 15:03 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da84ade4-6d66-7728-7edd-3d128aa43f0f@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).