From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Sven Schnelle <svens@stackframe.org>,
Helge Deller <deller@gmx.de>
Cc: peter.maydell@linaro.org
Subject: Re: [PULL 00/11] target/hppa patch queue
Date: Thu, 23 Jan 2020 00:28:37 +0100 [thread overview]
Message-ID: <da98d952-80e6-750a-3324-32723037b94f@redhat.com> (raw)
In-Reply-To: <b7c91905-f1bb-a3ea-e39c-08a27b2ff36e@linaro.org>
On 1/22/20 3:47 AM, Richard Henderson wrote:
> On 1/21/20 4:32 PM, Richard Henderson wrote:
>> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40:
>>
>> Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000)
>>
>> are available in the Git repository at:
>>
>> https://github.com/rth7680/qemu.git tags/pull-pa-20200121
>>
>> for you to fetch changes up to a66cfb7306b7cf7a023e11536fdd942f3f9276b9:
>>
>> target/hppa: Allow, but diagnose, LDCW aligned only mod 4 (2020-01-21 15:51:54 -1000)
>>
>> ----------------------------------------------------------------
>> Improve LASI emulation
>> Add Artist graphics
>> Fix main memory allocation
>> Improve LDCW emulation wrt real hw
>
> Ho hum. Cancel this. It breaks the hppa boot-serial test.
This is due to patch #7 "Add emulation of Artist graphics":
130 /* Graphics setup. */
131 if (machine->enable_graphics && vga_interface_type != VGA_NONE) {
132 dev = qdev_create(NULL, "artist");
133 qdev_init_nofail(dev);
134 s = SYS_BUS_DEVICE(dev);
135 sysbus_mmio_map(s, 0, LASI_GFX_HPA);
136 sysbus_mmio_map(s, 1, ARTIST_FB_ADDR);
137 }
The hppa boot-serial test use the default options, so the Artist chipset
is mapped, and the firmware test/use it.
We can test like the 40p, using VGA_NONE:
-- >8 --
diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
index 05c7f44457..971254ae62 100644
--- a/tests/qtest/boot-serial-test.c
+++ b/tests/qtest/boot-serial-test.c
@@ -135,7 +135,7 @@ static testdef_t tests[] = {
sizeof(kernel_plml605), kernel_plml605 },
{ "moxie", "moxiesim", "", "TT", sizeof(bios_moxiesim), 0,
bios_moxiesim },
{ "arm", "raspi2", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 },
- { "hppa", "hppa", "", "SeaBIOS wants SYSTEM HALT" },
+ { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" },
{ "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64),
kernel_aarch64 },
{ "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
---
You should squash this change in patch #7 (because it belongs there) but
please add a comment, because it is not obvious.
Thanks,
Phil.
next prev parent reply other threads:[~2020-01-22 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 2:32 [PULL 00/11] target/hppa patch queue Richard Henderson
2020-01-22 2:32 ` [PULL 01/11] hw/hppa/dino.c: Improve emulation of Dino PCI chip Richard Henderson
2020-01-22 2:32 ` [PULL 02/11] hppa: Add support for LASI chip with i82596 NIC Richard Henderson
2020-01-22 2:32 ` [PULL 03/11] ps2: accept 'Set Key Make and Break' commands Richard Henderson
2020-01-22 2:32 ` [PULL 04/11] hppa: add emulation of LASI PS2 controllers Richard Henderson
2020-01-22 2:32 ` [PULL 05/11] hppa: Switch to tulip NIC by default Richard Henderson
2020-01-22 2:32 ` [PULL 06/11] seabios-hppa: update to latest version Richard Henderson
2020-01-22 2:32 ` [PULL 07/11] hppa: Add emulation of Artist graphics Richard Henderson
2020-01-22 2:32 ` [PULL 08/11] hw/hppa/machine: Correctly check the firmware is in PDC range Richard Henderson
2020-01-22 2:32 ` [PULL 09/11] hw/hppa/machine: Restrict the total memory size to 3GB Richard Henderson
2020-01-22 2:32 ` [PULL 10/11] hw/hppa/machine: Map the PDC memory region with higher priority Richard Henderson
2020-01-22 2:32 ` [PULL 11/11] target/hppa: Allow, but diagnose, LDCW aligned only mod 4 Richard Henderson
2020-01-22 2:47 ` [PULL 00/11] target/hppa patch queue Richard Henderson
2020-01-22 23:28 ` Philippe Mathieu-Daudé [this message]
2020-01-22 23:34 ` Philippe Mathieu-Daudé
2020-01-22 23:59 ` Philippe Mathieu-Daudé
2020-01-22 3:34 ` no-reply
2020-01-22 14:40 ` Philippe Mathieu-Daudé
2020-01-27 19:01 [PATCH " Richard Henderson
2020-01-27 19:08 ` [PULL " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da98d952-80e6-750a-3324-32723037b94f@redhat.com \
--to=philmd@redhat.com \
--cc=deller@gmx.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).