From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH 6/7] gitlab-ci: Determine the number of jobs dynamically
Date: Thu, 28 May 2020 11:11:52 +0200 [thread overview]
Message-ID: <db3e3dfe-f0b8-4947-1fd7-c50e57bb2040@redhat.com> (raw)
In-Reply-To: <87pnao4fjs.fsf@linaro.org>
On 28/05/2020 10.41, Alex Bennée wrote:
>
> Thomas Huth <thuth@redhat.com> writes:
>
>> Some people might want to run the gitlab CI pipelines in an environment
>> where multiple CPUs are available to the runners, so let's rather get
>> the number for "-j" from the "nproc" program (increased by 1 to compensate
>> for jobs that wait for I/O) instead of hard-coding it.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> <snip>
>> @@ -25,8 +27,8 @@ build-system1:
>> - ../configure --enable-werror --target-list="aarch64-softmmu alpha-softmmu
>> cris-softmmu hppa-softmmu lm32-softmmu moxie-softmmu microblazeel-softmmu
>> mips64el-softmmu m68k-softmmu ppc-softmmu riscv64-softmmu sparc-softmmu"
>> - - make -j2
>> - - make -j2 check
>> + - make -j"$JOBS"
>> + - make -j"$JOBS" check
>>
>> build-system2:
>> image: fedora:latest
>> @@ -40,8 +42,8 @@ build-system2:
>> - ../configure --enable-werror --target-list="tricore-softmmu unicore32-softmmu
>> microblaze-softmmu mips-softmmu riscv32-softmmu s390x-softmmu sh4-softmmu
>> sparc64-softmmu x86_64-softmmu xtensa-softmmu nios2-softmmu or1k-softmmu"
>> - - make -j2
>> - - make -j2 check
>> + - make -j"$JOBS"
>> + - make -j"$JOBS" check
>>
>> build-disabled:
>> image: fedora:latest
>> @@ -56,8 +58,8 @@ build-disabled:
>> --disable-qom-cast-debug --disable-spice --disable-vhost-vsock
>> --disable-vhost-net --disable-vhost-crypto --disable-vhost-user
>> --target-list="i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user"
>> - - make -j2
>> - - make -j2 check-qtest SPEED=slow
>> + - make -j"$JOBS"
>> + - make -j"$JOBS" check-qtest SPEED=slow
>
> I would make all the check jobs use a single core as it otherwise gets
> hard to figure out exactly where something broke/hung.
It's a somewhat double-edged sword ... either faster CI test times, or
more deterministic output ... so far I didn't suffer the problem with
the deterministic output in the gitlab-CI yet (unlike with Travis), so
I'd rather keep the -j here for now. We can still remove it later if we
hit a bug that is hard to debug otherwise.
Thomas
next prev parent reply other threads:[~2020-05-28 9:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 13:18 [PATCH 0/7] Gitlab CI improvements and fixes Thomas Huth
2020-05-25 13:18 ` [PATCH 1/7] MAINTAINERS: Add Philippe, Alex and Wainer to the Gitlab-CI section Thomas Huth
2020-05-25 13:18 ` [PATCH 2/7] gitlab-ci: Remove flex/bison packages Thomas Huth
2020-05-27 16:47 ` Alex Bennée
2020-05-25 13:18 ` [PATCH 3/7] GitLab CI: avoid calling before_scripts on unintended jobs Thomas Huth
2020-05-27 17:33 ` Alex Bennée
2020-05-25 13:18 ` [PATCH 4/7] gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder Thomas Huth
2020-05-25 13:32 ` Philippe Mathieu-Daudé
2020-05-27 17:34 ` Alex Bennée
2020-05-25 13:18 ` [PATCH 5/7] gitlab-ci: Do not use the standard container images from gitlab Thomas Huth
2020-05-28 8:37 ` Alex Bennée
2020-05-25 13:18 ` [PATCH 6/7] gitlab-ci: Determine the number of jobs dynamically Thomas Huth
2020-05-28 8:41 ` Alex Bennée
2020-05-28 9:11 ` Thomas Huth [this message]
2020-05-25 13:18 ` [PATCH 7/7] linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS Thomas Huth
2020-05-27 14:44 ` Laurent Vivier
2020-05-27 14:51 ` Thomas Huth
2020-05-27 16:36 ` Alex Bennée
2020-05-28 6:45 ` Thomas Huth
2020-05-28 8:31 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db3e3dfe-f0b8-4947-1fd7-c50e57bb2040@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).