From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592B8C5321D for ; Wed, 25 Mar 2020 17:37:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CCCF20777 for ; Wed, 25 Mar 2020 17:37:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TH8gTdC1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CCCF20777 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH9xx-0008CT-Ch for qemu-devel@archiver.kernel.org; Wed, 25 Mar 2020 13:37:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32928) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH9ws-0006lv-BY for qemu-devel@nongnu.org; Wed, 25 Mar 2020 13:36:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH9wq-0005s3-3z for qemu-devel@nongnu.org; Wed, 25 Mar 2020 13:36:13 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:25126) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH9wp-0005rD-Ho for qemu-devel@nongnu.org; Wed, 25 Mar 2020 13:36:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585157769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fGCIKjr6Q14PUCx8WbUNdC86DKO+ZhNmIC/2FB/3FAg=; b=TH8gTdC1MroA9+qJ5n+DoRDdUulkA7Lyc759S0HHYjEQQEF8k/nqi0CZnmz/rveQ7n+qRu fdHkOO29W3JV1qdMr41JnSCPZorO3+93kA0x8SPRnJOWgyE9TreaBgJd0cnV4TS5ZU6a9F 9bk0PHnb/3oAXZBipKEpsilxwS6pNno= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-yZmQfvybNrCeQZFdq3A-Pw-1; Wed, 25 Mar 2020 13:36:05 -0400 X-MC-Unique: yZmQfvybNrCeQZFdq3A-Pw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A9C4477; Wed, 25 Mar 2020 17:36:04 +0000 (UTC) Received: from [10.3.113.103] (ovpn-113-103.phx2.redhat.com [10.3.113.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41E135C1B0; Wed, 25 Mar 2020 17:36:01 +0000 (UTC) Subject: Re: [PATCH 1/2] Revert "mirror: Don't let an operation wait for itself" To: Kevin Wolf , qemu-block@nongnu.org References: <20200325172326.22347-1-kwolf@redhat.com> <20200325172326.22347-2-kwolf@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 25 Mar 2020 12:36:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200325172326.22347-2-kwolf@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/25/20 12:23 PM, Kevin Wolf wrote: > This reverts commit 7e6c4ff792734e196c8ca82564c56b5e7c6288ca. > > The fix was incomplete as it only protected against requests waiting for > themselves, but not against requests waiting for each other. We need a > different solution. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org