From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>,
Igor Mammedov <imammedo@redhat.com>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
qemu-ppc@nongnu.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
Date: Wed, 12 May 2021 06:53:22 +0200 [thread overview]
Message-ID: <dba0c284-b279-5e5b-74c9-2da719a8ce2e@redhat.com> (raw)
In-Reply-To: <21e0a306-ccfb-a627-1496-14f831fe80a7@redhat.com>
On 12/05/2021 05.57, Philippe Mathieu-Daudé wrote:
> On 5/12/21 4:24 AM, David Gibson wrote:
>> On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daudé wrote:
>>> Per the kconfig.rst:
>>>
>>> A device should be listed [...] ``imply`` if (depending on
>>> the QEMU command line) the board may or may not be started
>>> without it.
>>>
>>> This is the case with the NVDIMM device, so use the 'imply'
>>> weak reverse dependency to select the symbol.
>>
>> Uh.. It should definitely be possible to start a pseries machine
>> without NVDIMM. I would have guessed the same for PC.
>
> Yes, this is what this patch does. With it we can build with:
> CONFIG_NVDIMM=n
But with "imply" you could end up with a PSERIES that does not have NVDIMM
when also using --without-default-devices, couldn't you? Why don't you use
"select" instead of "imply" ?
Thomas
next prev parent reply other threads:[~2021-05-12 4:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 15:53 [RFC PATCH 0/5] buildsys: Do not use internal fdt library when asked for the system one Philippe Mathieu-Daudé
2021-05-11 15:53 ` [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Philippe Mathieu-Daudé
2021-05-12 2:24 ` David Gibson
2021-05-12 3:57 ` Philippe Mathieu-Daudé
2021-05-12 4:53 ` Thomas Huth [this message]
2021-05-12 5:08 ` Philippe Mathieu-Daudé
2021-05-12 5:30 ` Thomas Huth
2021-05-12 7:02 ` David Gibson
2021-05-13 15:20 ` Paolo Bonzini
2021-05-13 23:33 ` David Gibson
2021-05-12 8:02 ` Paolo Bonzini
2021-05-11 15:53 ` [RFC PATCH 2/5] Kconfig: Declare 'FDT' host symbol Philippe Mathieu-Daudé
2021-05-12 7:37 ` Paolo Bonzini
2021-05-11 15:53 ` [RFC PATCH 3/5] hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol) Philippe Mathieu-Daudé
2021-05-12 2:27 ` David Gibson
2021-05-12 8:01 ` Paolo Bonzini
2021-05-13 3:46 ` David Gibson
2021-05-12 7:45 ` Paolo Bonzini
2021-05-12 8:27 ` Philippe Mathieu-Daudé
2021-05-11 15:53 ` [RFC PATCH 4/5] hw/ppc/fdt: Drop dependency on libfdt Philippe Mathieu-Daudé
2021-05-12 2:30 ` David Gibson
2021-05-12 7:59 ` Paolo Bonzini
2021-05-13 3:46 ` David Gibson
2021-05-13 15:26 ` Paolo Bonzini
2021-05-13 23:35 ` David Gibson
2021-05-14 5:29 ` Paolo Bonzini
2021-05-14 8:22 ` Philippe Mathieu-Daudé
2021-05-11 15:53 ` [RFC PATCH 5/5] meson: Do not use internal fdt library if user asked for the system one Philippe Mathieu-Daudé
2021-05-12 7:32 ` Paolo Bonzini
2021-05-11 15:57 ` [RFC PATCH 0/5] buildsys: Do not use internal fdt library when " Philippe Mathieu-Daudé
2021-05-12 3:56 ` Philippe Mathieu-Daudé
2021-05-12 7:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba0c284-b279-5e5b-74c9-2da719a8ce2e@redhat.com \
--to=thuth@redhat.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).