From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49218C48BD3 for ; Wed, 26 Jun 2019 17:56:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2141D208E3 for ; Wed, 26 Jun 2019 17:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2141D208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgCAA-0003R5-2C for qemu-devel@archiver.kernel.org; Wed, 26 Jun 2019 13:56:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35696) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgC9D-00030u-5Y for qemu-devel@nongnu.org; Wed, 26 Jun 2019 13:55:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgC9C-0007w0-4x for qemu-devel@nongnu.org; Wed, 26 Jun 2019 13:55:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36242) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgC9B-0007vH-Qr for qemu-devel@nongnu.org; Wed, 26 Jun 2019 13:55:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96EBC5F79B; Wed, 26 Jun 2019 17:55:51 +0000 (UTC) Received: from [10.3.116.44] (ovpn-116-44.phx2.redhat.com [10.3.116.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64B785D717; Wed, 26 Jun 2019 17:55:44 +0000 (UTC) To: "Michael S. Tsirkin" , qemu-devel@nongnu.org References: <20190616213540.20430-1-mst@redhat.com> <20190605145829.7674-3-marcandre.lureau@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Wed, 26 Jun 2019 12:55:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190605145829.7674-3-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hXh2DXitvj5N7lWjjwIHIu7Ly8YRLJZTz" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 26 Jun 2019 17:55:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL 02/11] vhost-user: check unix_listen() return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Gerd Hoffmann , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hXh2DXitvj5N7lWjjwIHIu7Ly8YRLJZTz Content-Type: multipart/mixed; boundary="s3ubgjMHtnHdp4YSjJqaQvBgTZEZQjeNX"; protected-headers="v1" From: Eric Blake To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Gerd Hoffmann , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Message-ID: Subject: Re: [Qemu-devel] [PULL 02/11] vhost-user: check unix_listen() return value References: <20190616213540.20430-1-mst@redhat.com> <20190605145829.7674-3-marcandre.lureau@redhat.com> In-Reply-To: <20190605145829.7674-3-marcandre.lureau@redhat.com> --s3ubgjMHtnHdp4YSjJqaQvBgTZEZQjeNX Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/16/19 4:36 PM, Michael S. Tsirkin wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > This check shouldn't be necessary, since &error_fatal is given as > argument and will exit() on failure. However, this change should > silence coverity CID 1401761 & 1401705. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Message-Id: <20190605145829.7674-3-marcandre.lureau@redhat.com> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > contrib/vhost-user-gpu/main.c | 4 ++++ > contrib/vhost-user-input/main.c | 4 ++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/contrib/vhost-user-gpu/main.c b/contrib/vhost-user-gpu/mai= n.c > index 9614c9422c..e0b6df5b4d 100644 > --- a/contrib/vhost-user-gpu/main.c > +++ b/contrib/vhost-user-gpu/main.c > @@ -1160,6 +1160,10 @@ main(int argc, char *argv[]) > =20 > if (opt_socket_path) { > int lsock =3D unix_listen(opt_socket_path, &error_fatal); > + if (lsock < 0) { > + g_printerr("Failed to listen on %s.\n", opt_socket_path); > + exit(EXIT_FAILURE); > + } 4 lines to appease Coverity; wouldn't the following one-liner also do the trick? int lsock =3D unix_listen(opt_socket_path, &error_fatal); assert (lsock >=3D 0); --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --s3ubgjMHtnHdp4YSjJqaQvBgTZEZQjeNX-- --hXh2DXitvj5N7lWjjwIHIu7Ly8YRLJZTz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0TsZ8ACgkQp6FrSiUn Q2oG4Qf+PoG0qQizieYa6KpvfhpL80YNPm15xtjQvAiQqtAsjDEo4eMbdxM5Iuh4 EpoPy8KIZwqq7iWRmntZ0rRZvlJQbrugojHTYXZlBw7YsX8bgvqMkzw/hJO4VlS8 OCbN9EhMbw2peA2A82qfYli4li8FYhC5kGG74lxRKWqYM2zprAlTArZCpCGxPcc6 biRvAs365GMgiwC3i9lY8N+mQpg/eTbZ1iEbx82SvR1gpnv6yRF2W119JdcsZa3k VQTz0MoISge+my74MWBHSPxdeyQRdBokcToVts9Dgmpju+5Bh/VJaWz5R9xXcb66 IMWkIwRhsVSRPAknghMoWWzAoiV3xw== =2/Po -----END PGP SIGNATURE----- --hXh2DXitvj5N7lWjjwIHIu7Ly8YRLJZTz--