From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>, Cleber Rosa <crosa@redhat.com>
Cc: "Hyman Huang" <huangy81@chinatelecom.cn>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] tests/migration: fix unix socket migration
Date: Wed, 28 Apr 2021 14:26:47 -0300 [thread overview]
Message-ID: <decc942d-c801-f460-d2aa-d75756551c61@redhat.com> (raw)
In-Reply-To: <4b1e91a5-73e8-912a-32c4-b78a7412a8bc@chinatelecom.cn>
Cleber,
Maybe you could review then queue this one?
- Wainer
On 4/20/21 10:16 PM, Hyman Huang wrote:
>
> 在 2021/3/10 0:55, Philippe Mathieu-Daudé 写道:
>> On 3/9/21 5:00 PM, huangy81@chinatelecom.cn wrote:
>>> From: Hyman <huangy81@chinatelecom.cn>
>>>
>>> The test aborts and error message as the following be throwed:
>>> "No such file or directory: '/var/tmp/qemu-migrate-{pid}.migrate",
>>> when the unix socket migration test nearly done. The reason is
>>> qemu removes the unix socket file after migration before
>>> guestperf.py script do it. So pre-check if the socket file exists
>>> when removing it to prevent the guestperf program from aborting.
>>>
>>> Signed-off-by: Hyman <huangy81@chinatelecom.cn>
>>> ---
>>> tests/migration/guestperf/engine.py | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Interesting, we have in MAINTAINERS:
>>
>> Python scripts
>> M: Eduardo Habkost <ehabkost@redhat.com>
>> M: Cleber Rosa <crosa@redhat.com>
>> S: Odd Fixes
>> F: scripts/*.py
>> F: tests/*.py
>>
>> However:
>>
>> ./scripts/get_maintainer.pl -f tests/migration/guestperf/engine.py
>> get_maintainer.pl: No maintainers found, printing recent contributors.
>> get_maintainer.pl: Do not blindly cc: them on patches! Use common
>> sense.
>
> Ping
>
> The following patch has fixed it
> https://patchew.org/QEMU/91d5978357fb8709ef61d2030984f7142847037d.1616141556.git.huangy81@chinatelecom.cn/
>
>
>>
>>> diff --git a/tests/migration/guestperf/engine.py
>>> b/tests/migration/guestperf/engine.py
>>> index 83bfc3b..86d4f21 100644
>>> --- a/tests/migration/guestperf/engine.py
>>> +++ b/tests/migration/guestperf/engine.py
>>> @@ -405,7 +405,7 @@ def run(self, hardware, scenario,
>>> result_dir=os.getcwd()):
>>> progress_history = ret[0]
>>> qemu_timings = ret[1]
>>> vcpu_timings = ret[2]
>>> - if uri[0:5] == "unix:":
>>> + if uri[0:5] == "unix:" and os.path.exists(uri[5:]):
>>> os.remove(uri[5:])
>>> if self._verbose:
>>> print("Finished migration")
>>>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
next prev parent reply other threads:[~2021-04-28 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 16:00 [PATCH] tests/migration: fix unix socket migration huangy81
2021-03-09 16:55 ` Philippe Mathieu-Daudé
2021-04-21 1:16 ` Hyman Huang
2021-04-28 17:26 ` Wainer dos Santos Moschetta [this message]
2021-06-25 16:33 ` Hyman
2021-07-07 7:31 ` Hyman Huang
2021-03-09 18:56 ` Wainer dos Santos Moschetta
2021-07-07 8:28 ` Philippe Mathieu-Daudé
2021-07-09 17:25 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=decc942d-c801-f460-d2aa-d75756551c61@redhat.com \
--to=wainersm@redhat.com \
--cc=crosa@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).