qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>
Cc: fam@euphon.net, berrange@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
	aurelien@aurel32.net
Subject: Re: [PATCH v1 13/25] hw/tricore: Add testdevice for tests in tests/tcg/
Date: Mon, 26 Apr 2021 11:37:57 +0200	[thread overview]
Message-ID: <df3cbf07-562f-087d-47b2-6b366c11f4ae@amsat.org> (raw)
In-Reply-To: <20210419145435.14083-14-alex.bennee@linaro.org>

On 4/19/21 4:54 PM, Alex Bennée wrote:
> From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> 
> this device is used to verify the correctness of regression tests by
> allowing guests to write their exit status to this device. This is then
> used by qemu to exit using the written status.
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20210305170045.869437-4-kbastian@mail.uni-paderborn.de>
> ---
>  include/hw/tricore/tricore_testdevice.h | 38 ++++++++++++
>  hw/tricore/tricore_testboard.c          |  8 +++
>  hw/tricore/tricore_testdevice.c         | 82 +++++++++++++++++++++++++
>  hw/tricore/meson.build                  |  1 +
>  4 files changed, 129 insertions(+)
>  create mode 100644 include/hw/tricore/tricore_testdevice.h
>  create mode 100644 hw/tricore/tricore_testdevice.c

> +#include "hw/tricore/tricore_testdevice.h"
> +
> +static void tricore_testdevice_write(void *opaque, hwaddr offset,
> +                                      uint64_t value, unsigned size)
> +{
> +    exit(value);

   ->  qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);

I'd rather use a 2 steps check of value such watchdog devices do
(to be sure the guest is still in control and isn't nut).


A general comments, all targets require a such test feature,
so we should have a generic user-creatable sysbus-testdev for that.

Regards,

Phil.


  reply	other threads:[~2021-04-26  9:40 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 14:54 [PATCH for post 6.0 v1 00/25] testing/next (hexagon/tricore/test cc) Alex Bennée
2021-04-19 14:54 ` [PATCH v1 01/25] checkpatch: Fix use of uninitialized value Alex Bennée
2021-04-19 14:54 ` [PATCH v1 02/25] tests/docker: fix copying of executable in "update" Alex Bennée
2021-04-23 17:35   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 03/25] tests/docker: make executable an optional argument to "update" Alex Bennée
2021-04-23 17:37   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 04/25] tests/docker: allow "update" to add the current user Alex Bennée
2021-04-23 18:35   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 05/25] tests/docker: add "fetch" sub-command Alex Bennée
2021-04-23 18:37   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 06/25] docker: Add Hexagon image Alex Bennée
2021-04-23 18:41   ` Willian Rampazzo
2021-04-23 22:25   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 07/25] tests/tcg: Use Hexagon Docker image Alex Bennée
2021-04-23 22:23   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 08/25] gitlab: add build-user-hexagon test Alex Bennée
2021-04-23 18:38   ` Willian Rampazzo
2021-04-23 22:23   ` Philippe Mathieu-Daudé
2021-05-11 14:41   ` Alex Bennée
2021-05-11 14:53     ` Brian Cain
2021-05-11 15:08       ` Brian Cain
2021-05-12  7:34         ` Alex Bennée
2021-04-19 14:54 ` [PATCH v1 09/25] tests/tcg: don't iterate through other arch compilers Alex Bennée
2021-04-19 14:54 ` [PATCH v1 10/25] tests/docker: Added libbpf library to the docker files Alex Bennée
2021-04-23 18:39   ` Willian Rampazzo
2021-04-23 22:30   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 11/25] tests/tcg: Add docker_as and docker_ld cmds Alex Bennée
2021-04-23 22:31   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 12/25] tests/tcg: Run timeout cmds using --foreground Alex Bennée
2021-04-19 14:54 ` [PATCH v1 13/25] hw/tricore: Add testdevice for tests in tests/tcg/ Alex Bennée
2021-04-26  9:37   ` Philippe Mathieu-Daudé [this message]
2021-04-26 10:15     ` Alex Bennée
2021-04-26 12:03       ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 14/25] tests/tcg/tricore: Add build infrastructure Alex Bennée
2021-04-19 14:54 ` [PATCH v1 15/25] configure: Emit HOST_CC to config-host.mak Alex Bennée
2021-04-19 14:54 ` [PATCH v1 16/25] tests/tcg/tricore: Add macros to create tests and first test 'abs' Alex Bennée
2021-04-19 14:54 ` [PATCH v1 17/25] tests/tcg/tricore: Add bmerge test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 18/25] tests/tcg/tricore: Add clz test Alex Bennée
2021-04-29 13:53   ` Bastian Koppelmann
2021-04-19 14:54 ` [PATCH v1 19/25] tests/tcg/tricore: Add dvstep test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 20/25] tests/tcg/tricore: Add fadd test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 21/25] tests/tcg/tricore: Add fmul test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 22/25] tests/tcg/tricore: Add ftoi test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 23/25] tests/tcg/tricore: Add madd test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 24/25] tests/tcg/tricore: Add msub test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 25/25] tests/tcg/tricore: Add muls test Alex Bennée
2021-04-19 15:51 ` [PATCH for post 6.0 v1 00/25] testing/next (hexagon/tricore/test cc) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df3cbf07-562f-087d-47b2-6b366c11f4ae@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=fam@euphon.net \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).