From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Lukáš Doktor" <ldoktor@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] block/file-posix: Fix xfs_write_zeroes()
Date: Thu, 22 Aug 2019 19:09:04 +0200 [thread overview]
Message-ID: <dfafe489-9e42-e37c-7695-e42b7c413c4b@redhat.com> (raw)
In-Reply-To: <47d2cafd-da56-eb81-b54f-4f666aff016f@redhat.com>
On 22.08.19 18:53, Paolo Bonzini wrote:
> On 22/08/19 18:26, Max Reitz wrote:
>> Lukàš ran over a nasty regression in our xfs_write_zeroes() function
>> (sorry, my fault) made apparent by a recent patch from Anton that makes
>> qcow2 images heavily exercise the offending code path.
>>
>> This series fixes the bug and adds a test to prevent it from
>> reoccurring.
>>
>>
>> Max Reitz (2):
>> block/file-posix: Fix xfs_write_zeroes()
>> iotests: Test reverse sub-cluster qcow2 writes
>>
>> block/file-posix.c | 16 ++++++---
>> tests/qemu-iotests/265 | 67 ++++++++++++++++++++++++++++++++++++++
>> tests/qemu-iotests/265.out | 6 ++++
>> tests/qemu-iotests/group | 1 +
>> 4 files changed, 85 insertions(+), 5 deletions(-)
>> create mode 100755 tests/qemu-iotests/265
>> create mode 100644 tests/qemu-iotests/265.out
>>
>
> What about just killing libxfs support and only use fallocate?
> FALLOC_FL_ZERO_RANGE was added in Linux 3.15 (2014) and the only
> platform we probably support with such an old kernel is of course
> RHEL/CentOS 7 which has had it backported.
Works just as well for me. :-)
Max
next prev parent reply other threads:[~2019-08-22 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 16:26 [Qemu-devel] [PATCH 0/2] block/file-posix: Fix xfs_write_zeroes() Max Reitz
2019-08-22 16:26 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2019-08-22 16:26 ` [Qemu-devel] [PATCH 2/2] iotests: Test reverse sub-cluster qcow2 writes Max Reitz
2019-08-22 16:53 ` [Qemu-devel] [PATCH 0/2] block/file-posix: Fix xfs_write_zeroes() Paolo Bonzini
2019-08-22 17:09 ` Max Reitz [this message]
2019-08-23 6:28 ` Lukáš Doktor
2019-08-23 8:16 ` Anton Nefedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfafe489-9e42-e37c-7695-e42b7c413c4b@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).