qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Dongli Zhang <dongli.zhang@oracle.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, berrange@redhat.com,
	ehabkost@redhat.com, mst@redhat.com, joe.jin@oracle.com,
	armbru@redhat.com, dgilbert@redhat.com, stefanha@redhat.com,
	pbonzini@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH 0/6] Add debug interface to kick/call on purpose
Date: Thu, 8 Apr 2021 13:59:40 +0800	[thread overview]
Message-ID: <e02cf3d6-29ce-8421-63c6-4d2bcbf9d25c@redhat.com> (raw)
In-Reply-To: <7074ef2d-8410-3815-791b-84c3e034e872@oracle.com>


在 2021/4/8 下午1:51, Dongli Zhang 写道:
>
> On 4/6/21 7:20 PM, Jason Wang wrote:
>> 在 2021/4/7 上午7:27, Dongli Zhang 写道:
>>>> This will answer your question that "Can it bypass the masking?".
>>>>
>>>> For vhost-scsi, virtio-blk, virtio-scsi and virtio-net, to write to eventfd is
>>>> not able to bypass masking because masking is to unregister the eventfd. To
>>>> write to eventfd does not take effect.
>>>>
>>>> However, it is possible to bypass masking for vhost-net because vhost-net
>>>> registered a specific masked_notifier eventfd in order to mask irq. To write to
>>>> original eventfd still takes effect.
>>>>
>>>> We may leave the user to decide whether to write to 'masked_notifier' or
>>>> original 'guest_notifier' for vhost-net.
>>> My fault here. To write to masked_notifier will always be masked:(
>>
>> Only when there's no bug in the qemu.
>>
>>
>>> If it is EventNotifier level, we will not care whether the EventNotifier is
>>> masked or not. It just provides an interface to write to EventNotifier.
>>
>> Yes.
>>
>>
>>> To dump the MSI-x table for both virtio and vfio will help confirm if the vector
>>> is masked.
>>
>> That would be helpful as well. It's probably better to extend "info pci" command.
>>
>> Thanks
> I will try if to add to "info pci" (introduce new arg option to "info pci"), or
> to introduce new command.


It's better to just reuse "info pci".


>
> About the EventNotifier, I will classify them as guest notifier or host notifier
> so that it will be much more easier for user to tell if the eventfd is for
> injecting IRQ or kicking the doorbell.


Sounds good.


>
> Thank you very much for all suggestions!
>
> Dongli Zhang


Thanks


>>
>>> Thank you very much!
>>>
>>> Dongli Zhang
>>>



  reply	other threads:[~2021-04-08  6:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  5:44 [PATCH 0/6] Add debug interface to kick/call on purpose Dongli Zhang
2021-03-26  5:44 ` [PATCH 1/6] qdev: introduce qapi/hmp command for kick/call event Dongli Zhang
2021-04-07 13:40   ` Eduardo Habkost
2021-04-08  5:49     ` Dongli Zhang
2021-03-26  5:44 ` [PATCH 2/6] virtio: introduce helper function for kick/call device event Dongli Zhang
2021-03-26  5:44 ` [PATCH 3/6] virtio-blk-pci: implement device event interface for kick/call Dongli Zhang
2021-03-26  5:44 ` [PATCH 4/6] virtio-scsi-pci: " Dongli Zhang
2021-03-26  5:44 ` [PATCH 5/6] vhost-scsi-pci: " Dongli Zhang
2021-03-26  5:44 ` [PATCH 6/6] virtio-net-pci: " Dongli Zhang
2021-03-26  7:24 ` [PATCH 0/6] Add debug interface to kick/call on purpose Jason Wang
2021-03-26 21:16   ` Dongli Zhang
2021-03-29  3:56     ` Jason Wang
2021-03-30  7:29       ` Dongli Zhang
2021-04-02  3:47         ` Jason Wang
2021-04-05 20:00           ` Dongli Zhang
2021-04-06  1:55             ` Jason Wang
2021-04-06  8:43               ` Dongli Zhang
2021-04-06 23:27                 ` Dongli Zhang
2021-04-07  2:20                   ` Jason Wang
2021-04-08  5:51                     ` Dongli Zhang
2021-04-08  5:59                       ` Jason Wang [this message]
2021-04-07  2:18                 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e02cf3d6-29ce-8421-63c6-4d2bcbf9d25c@redhat.com \
    --to=jasowang@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dongli.zhang@oracle.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=joe.jin@oracle.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).