From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D83C33CB6 for ; Tue, 14 Jan 2020 12:37:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AD8D24672 for ; Tue, 14 Jan 2020 12:37:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AD8D24672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irLS0-0003j6-FM for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 07:37:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37392) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irLRN-0003Ii-R1 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 07:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irLRK-0004jf-7g for qemu-devel@nongnu.org; Tue, 14 Jan 2020 07:37:01 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:33117) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irLRJ-0004jX-Ul for qemu-devel@nongnu.org; Tue, 14 Jan 2020 07:36:58 -0500 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.103]) with ESMTPSA (Nemesis) id 1M9qYn-1ilY0S1ogf-005uK0; Tue, 14 Jan 2020 13:36:41 +0100 Subject: Re: [PATCH 03/12] linux-user: Add support for getting/setting RTC periodic interrupt and epoch using ioctls To: Filip Bozuta , qemu-devel@nongnu.org References: <1578574763-8327-1-git-send-email-Filip.Bozuta@rt-rk.com> <1578574763-8327-4-git-send-email-Filip.Bozuta@rt-rk.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Tue, 14 Jan 2020 13:36:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <1578574763-8327-4-git-send-email-Filip.Bozuta@rt-rk.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:9Sd2vzGuPqsxOHX6osxhw21GrV+EEah5bX0OKWY3AnjimsChz04 rfT36aQsT7/C9BSxZJ65guus8YoDsx27qPEhY15jIiOSv4G6N8xPXVfa/YxFQbes9wtzoMt Euz7/1u5nnDCuVXRzSdG6UnpwVS0AVUF4jVzhPAUL9kzat1ZNtZsw0BxQy0IqwH0ca3bjEu ByYFQfFO/7O+6HtfKrh6g== X-UI-Out-Filterresults: notjunk:1;V03:K0:fxQPNlS0oXA=:Mqj+6IVDSatcgoVSkVeno5 C5q9ird4EXYcBDERwqB49+GWB9qPcKe4XhkJ675FPu03SWoVA5H+AvNQedL5p+9rSmGV4R/ux p7wReWUuei8WgdRAJ+XESfbJqF96LjFG0NJFiIty70pjGFx6vUXbi94G//PkXaPKsue0Q5ASJ OuuoShF+V6n5SRKEZCajF5wTFOgLk2JOTKrmxO7CktAPFOewPfo8P8SDe5KUMNs7Riyb9naAY A3pbWINkJnLxjh9Kpb4HeiijmjPw94pEqpe2Fu119/YP8f+COhOE1eKFtUkAP7PSi7IhF6LR6 YqJvFNFwa6xVeqeWy1MGOYprQrqObHSspLBaH8dhkqdKdE5w8vdbcotZrqfV2cwOH2I/yOlYg wo9Q5nRNI2Kr1E9QXyuUthi9BAPssUVFe7VBOQi/ivGrpTynhpO6Vp74n4GNeYUITaXTaKr0r sOnCok4C+saMZfDTpVBUkjm9KyyjHkjp8DQqORzVuQ49E/WYb2qsb/do2NcB5BHrDz8H9OvS1 Z0AMT4EbJV3zdFbZuJUGfuNGUJ3ukrT9Ndporq2nKcO/QfnCEHtX3MOM9/ovKlZPyO8D+WpIx 5sW6q6jJd0dTax0N6tucRo8m315Xummk1jPA+Sfyn/5kM5xjUgVSYmuuZ1vCLjeurbiyQwhnR fSBSRqS3ikIaHZZ7dhS+3cPV57n38YHcvIjRLOyE6SX22D1UJ7UgKOGGaYbfXYU2mUzoeVNcX yjYSeOZrLDv4URHTsm4OXkZk944TrCJOmvkGedNCfS3fcwbGkTdE1YSYajFmfHM+qXYHPErRa veW2P+BUXaji0l0FtCT0Gjnh15tRY5wlYAgiVzbotg7E8WA8sz2Jc5c3wkNtBJ+VA67qCqp2P HgmB3Soymwl2Ya+lJ83Q== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.130 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: riku.voipio@iki.fi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 09/01/2020 à 13:59, Filip Bozuta a écrit : > This patch implements functionalities of following ioctls: > > RTC_IRQP_READ, RTC_IRQP_SET - Getting/Setting IRQ rate > > Read and set the frequency for periodic interrupts, for RTCs > that support periodic interrupts. The periodic interrupt must > be separately enabled or disabled using the RTC_PIE_ON, > RTC_PIE_OFF requests. The third ioctl's argument is an > unsigned long * or an unsigned long, respectively. The value > is the frequency in interrupts per second. The set of allow‐ > able frequencies is the multiples of two in the range 2 to > 8192. Only a privileged process (i.e., one having the > CAP_SYS_RESOURCE capability) can set frequencies above the > value specified in /proc/sys/dev/rtc/max-user-freq. (This > file contains the value 64 by default.) > > RTC_EPOCH_READ, RTC_EPOCH_SET - Getting/Setting epoch > > Many RTCs encode the year in an 8-bit register which is either > interpreted as an 8-bit binary number or as a BCD number. In > both cases, the number is interpreted relative to this RTC's > Epoch. The RTC's Epoch is initialized to 1900 on most systems > but on Alpha and MIPS it might also be initialized to 1952, > 1980, or 2000, depending on the value of an RTC register for > the year. With some RTCs, these operations can be used to > read or to set the RTC's Epoch, respectively. The third > ioctl's argument is an unsigned long * or an unsigned long, > respectively, and the value returned (or assigned) is the > Epoch. To set the RTC's Epoch the process must be privileged > (i.e., have the CAP_SYS_TIME capability). > > Implementation notes: > > All ioctls in this patch have a pointer to 'ulong' as their > third argument. That is the reason why corresponding parts > of added code in linux-user/syscall_defs.h contain special > handling related to 'ulong' type: they use 'abi_ulong' type > to make sure that ioctl's code is calculated correctly for > both 32-bit and 64-bit targets. Also, 'MK_PTR(TYPE_ULONG)' > is used for the similar reason in linux-user/ioctls.h. > > Signed-off-by: Filip Bozuta > --- > linux-user/ioctls.h | 4 ++++ > linux-user/syscall_defs.h | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h > index f472794..accbdee 100644 > --- a/linux-user/ioctls.h > +++ b/linux-user/ioctls.h > @@ -81,6 +81,10 @@ > IOCTL(RTC_ALM_SET, IOC_W, MK_PTR(MK_STRUCT(STRUCT_rtc_time))) > IOCTL(RTC_RD_TIME, IOC_R, MK_PTR(MK_STRUCT(STRUCT_rtc_time))) > IOCTL(RTC_SET_TIME, IOC_W, MK_PTR(MK_STRUCT(STRUCT_rtc_time))) > + IOCTL(RTC_IRQP_READ, IOC_R, MK_PTR(TYPE_ULONG)) > + IOCTL(RTC_IRQP_SET, IOC_W, TYPE_ULONG) > + IOCTL(RTC_EPOCH_READ, IOC_R, MK_PTR(TYPE_ULONG)) > + IOCTL(RTC_EPOCH_SET, IOC_W, TYPE_ULONG) > > IOCTL(BLKROSET, IOC_W, MK_PTR(TYPE_INT)) > IOCTL(BLKROGET, IOC_R, MK_PTR(TYPE_INT)) > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h > index f0bf09d..bbfa935 100644 > --- a/linux-user/syscall_defs.h > +++ b/linux-user/syscall_defs.h > @@ -776,6 +776,10 @@ struct target_pollfd { > #define TARGET_RTC_ALM_SET TARGET_IOW('p', 0x07, struct rtc_time) > #define TARGET_RTC_RD_TIME TARGET_IOR('p', 0x09, struct rtc_time) > #define TARGET_RTC_SET_TIME TARGET_IOW('p', 0x0a, struct rtc_time) > +#define TARGET_RTC_IRQP_READ TARGET_IOR('p', 0x0b, abi_ulong) > +#define TARGET_RTC_IRQP_SET TARGET_IOW('p', 0x0c, abi_ulong) > +#define TARGET_RTC_EPOCH_READ TARGET_IOR('p', 0x0d, abi_ulong) > +#define TARGET_RTC_EPOCH_SET TARGET_IOW('p', 0x0e, abi_ulong) > > #if defined(TARGET_ALPHA) || defined(TARGET_MIPS) || defined(TARGET_SH4) || \ > defined(TARGET_XTENSA) > Reviewed-by: Laurent Vivier