From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B638C33CB1 for ; Thu, 16 Jan 2020 10:01:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC9952073A for ; Thu, 16 Jan 2020 10:01:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="CID4Z2SU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC9952073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=greensocs.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is1yO-0003p2-Rs for qemu-devel@archiver.kernel.org; Thu, 16 Jan 2020 05:01:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42259) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is1ve-0002ye-Dv for qemu-devel@nongnu.org; Thu, 16 Jan 2020 04:59:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is1vd-0002Fi-FP for qemu-devel@nongnu.org; Thu, 16 Jan 2020 04:59:06 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:33210) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1is1va-0002CI-7S; Thu, 16 Jan 2020 04:59:02 -0500 Received: from [172.16.11.102] (crumble.bar.greensocs.com [172.16.11.102]) by beetle.greensocs.com (Postfix) with ESMTPSA id 5C33396EF0; Thu, 16 Jan 2020 09:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1579168739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWggCHq2iVR6vAYfpXZ4nhLLYMEos/TRGVmYjXTFUWU=; b=CID4Z2SUnkjZwvSR+HkST/klc7AMaktQ2hQBNwRatGJljUsj9Uhsi4w62wyrVVJTGGMalw ZfjAVEfnpMESMPcCrf/Cd6o/7p4seOsYSFgjh91h3tOVmXSxYFSiglHm7UW2T5MFRV8rId V9PgyAbXUL4ASZgXM11IWFF/+1DWkao= Subject: Re: [PATCH v5 08/22] gdbstub: extend GByteArray to read register helpers To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20200114150953.27659-1-alex.bennee@linaro.org> <20200114150953.27659-9-alex.bennee@linaro.org> From: Damien Hedde Message-ID: Date: Thu, 16 Jan 2020 10:58:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200114150953.27659-9-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1579168739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWggCHq2iVR6vAYfpXZ4nhLLYMEos/TRGVmYjXTFUWU=; b=o1+u6b/JID6xTVs6KfoDaHnPeMu0bLT1P/h43XF1Xl+YSCOYhK16pMiJTMCR1BWyUEsZ0+ Blx067AZxAUfAUqu/gaQx1CEQGjGzIquLnvcbILKycFfDlKIGs1zanYiOu9UJkwsQ/UYLH Hveb7532MjMQY+VgJotRrCHITKtJUNU= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1579168739; a=rsa-sha256; cv=none; b=Yrmm4XQH7iXon0GAHvjIQRTKNugnh8S9fKPh6BJwz1znHl0absnQ4Me52Q48loIBdr3sC3 ZEUY7pK2oe5WwpkpxBmk2LX+Lq5dQy0TPAoZEco3sEGQ6xBJTLHLNlRdoNnSRCVl0rR8nu nlOzmtPh/11sWBW8mocjgURHZjv8BpU= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=damien smtp.mailfrom=damien.hedde@greensocs.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Chris Wulff , Sagar Karandikar , David Hildenbrand , Mark Cave-Ayland , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Marek Vasut , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Artyom Tarasenko , Eduardo Habkost , Richard Henderson , "open list:S390 TCG CPUs" , qemu-arm@nongnu.org, Stafford Horne , David Gibson , "open list:RISC-V TCG CPUs" , Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Michael Walle , "open list:PowerPC TCG CPUs" , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/14/20 4:09 PM, Alex Benn=C3=A9e wrote: > Instead of passing a pointer to memory now just extend the GByteArray > to all the read register helpers. They can then safely append their > data through the normal way. We don't bother with this abstraction for > write registers as we have already ensured the buffer being copied > from is the correct size. >=20 > Signed-off-by: Alex Benn=C3=A9e > Reviewed-by: Richard Henderson >=20 > --- > v4 > - fix mem_buf calculation for ppc_maybe_bswap_register > v5 > - introduce gdb_get_reg_ptr and use for ppc > --- Reviewed-by: Damien Hedde -- Damien