From: Collin Walling <walling@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com,
david@redhat.com
Subject: Re: [PATCH] s390x: kvm: adjust diag318 resets to retain data
Date: Mon, 8 Nov 2021 12:36:31 -0500 [thread overview]
Message-ID: <e1143c60-036d-311e-e5c7-8c6224710abc@linux.ibm.com> (raw)
In-Reply-To: <055031a8-64ad-63d0-0345-69d45b760a7a@linux.ibm.com>
On 11/8/21 12:02, Janosch Frank wrote:
> On 11/5/21 23:46, Collin Walling wrote:
>> The CPNC portion of the diag 318 data is erroneously reset during an
>> initial CPU reset caused by SIGP. Let's go ahead and relocate the
>> diag318_info field within the CPUS390XState struct such that it is
>> only zeroed during a clear reset. This way, the CPNC will be retained
>> for each VCPU in the configuration after the diag 318 instruction
>> has been invoked by the kernel.
>>
>> Additionally, the diag 318 data reset is handled via the CPU reset
>> code. The set_diag318 code can be merged into the handler function
>> and the helper functions can consequently be removed.
>>
>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>
> Fixes tag?
>
Will include this on v2 post. Thank you.
[...]
--
Regards,
Collin
Stay safe and stay healthy
next prev parent reply other threads:[~2021-11-08 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 22:46 [PATCH] s390x: kvm: adjust diag318 resets to retain data Collin Walling
2021-11-05 22:56 ` Collin Walling
2021-11-08 8:07 ` Christian Borntraeger
2021-11-08 15:12 ` Collin Walling
2021-11-08 17:02 ` Janosch Frank
2021-11-08 17:36 ` Collin Walling [this message]
2021-11-08 17:40 ` Christian Borntraeger
2021-11-08 18:03 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1143c60-036d-311e-e5c7-8c6224710abc@linux.ibm.com \
--to=walling@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).