From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, quintela@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
den@openvz.org, jsnow@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH v4 0/6] fix migration with bitmaps and mirror
Date: Fri, 22 May 2020 19:06:57 +0300 [thread overview]
Message-ID: <e1b1e8ea-9d29-1d63-8ebf-0d821c9e7e0b@virtuozzo.com> (raw)
In-Reply-To: <5f7b47b5-5b91-c82b-8057-c78fc7e225a2@redhat.com>
22.05.2020 18:24, Eric Blake wrote:
> On 5/21/20 5:06 PM, Vladimir Sementsov-Ogievskiy wrote:
>> v4: (Max's patch marking filters as filters already in master)
>> 03: careful select child of filter, avoid crash
>> 04: add Eric's r-b
>> 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b
>>
>> Vladimir Sementsov-Ogievskiy (6):
>> migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration
>> block/dirty-bitmap: add bdrv_has_named_bitmaps helper
>> migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration
>> during mirror job
>> iotests: 194: test also migration of dirty bitmap
>> migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name
>> once
>> migration/block-dirty-bitmap: forbid migration by generated node-name
>
> 3 and 5 have rather long subject lines, as shown by the wrapping inserted by git (3 even exceeds 80 columns on its own, even before git adds prefixing). Should I try to touch this up in my staging queue? For example:
>
> migration: fix non-blockdev bitmap migration with mirror
>
> doesn't lose too much information, but is definitely shorter for 3.
>
No objections, of course
--
Best regards,
Vladimir
prev parent reply other threads:[~2020-05-22 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 22:06 [PATCH v4 0/6] fix migration with bitmaps and mirror Vladimir Sementsov-Ogievskiy
2020-05-21 22:06 ` [PATCH v4 1/6] migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration Vladimir Sementsov-Ogievskiy
2020-05-21 22:06 ` [PATCH v4 2/6] block/dirty-bitmap: add bdrv_has_named_bitmaps helper Vladimir Sementsov-Ogievskiy
2020-05-21 22:06 ` [PATCH v4 3/6] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job Vladimir Sementsov-Ogievskiy
2020-05-22 12:58 ` Eric Blake
2020-05-21 22:06 ` [PATCH v4 4/6] iotests: 194: test also migration of dirty bitmap Vladimir Sementsov-Ogievskiy
2020-06-03 7:52 ` Thomas Huth
2020-06-03 8:06 ` Vladimir Sementsov-Ogievskiy
2020-06-04 7:21 ` Thomas Huth
2020-06-04 7:51 ` Vladimir Sementsov-Ogievskiy
2020-06-04 9:40 ` Thomas Huth
2020-05-21 22:06 ` [PATCH v4 5/6] migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name once Vladimir Sementsov-Ogievskiy
2020-05-21 22:06 ` [PATCH v4 6/6] migration/block-dirty-bitmap: forbid migration by generated node-name Vladimir Sementsov-Ogievskiy
2020-05-22 15:24 ` [PATCH v4 0/6] fix migration with bitmaps and mirror Eric Blake
2020-05-22 16:06 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1b1e8ea-9d29-1d63-8ebf-0d821c9e7e0b@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).