From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC
Date: Thu, 19 Sep 2019 09:01:13 -0700 [thread overview]
Message-ID: <e22f6316-aa1f-b037-2501-ed71dee09282@linaro.org> (raw)
In-Reply-To: <7995a66a-b1c6-2332-dd12-28ff69efa612@redhat.com>
On 9/19/19 2:41 AM, David Hildenbrand wrote:
>> + /* prepare the buffers - two consecutive pages */
>> + src = valloc(ALLOC_SIZE);
>> + dst = valloc(ALLOC_SIZE);
>
> If anybody cares, I can convert the obsolete valloc into a
> posix_memalign(&src, 4096, ALLOC_SIZE) etc.
I don't care. It may be obsolete, but it still works.
If you were to change it to anything I would think mmap
instead of using mprotect on the heap at all...
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-09-19 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 9:28 [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC David Hildenbrand
2019-09-19 9:41 ` David Hildenbrand
2019-09-19 16:01 ` Richard Henderson [this message]
2019-09-20 9:14 ` David Hildenbrand
2019-09-20 12:03 ` David Hildenbrand
2019-09-20 13:02 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22f6316-aa1f-b037-2501-ed71dee09282@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).