qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org
Cc: Yash Mankad <ymankad@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PULL 2/3] tests: Run the iotests during "make check" again
Date: Fri, 23 Aug 2019 10:59:42 +0200	[thread overview]
Message-ID: <e2b15899-7836-3957-97dc-91cd70b96ea3@redhat.com> (raw)
In-Reply-To: <4175e842-ba7c-a054-2ee6-8741b16416e0@redhat.com>

On 8/23/19 9:12 AM, Thomas Huth wrote:
> On 8/23/19 12:34 AM, Paolo Bonzini wrote:
>> On 17/08/19 10:54, Thomas Huth wrote:
>>> People often forget to run the iotests before submitting patches or pull
>>> requests - this is likely due to the fact that we do not run the tests
>>> during our mandatory "make check" tests yet. Now that we've got a proper
>>> "auto" group of iotests that should be fine to run in every environment,
>>> we can enable the iotests during "make check" again by running the "auto"
>>> tests by default from the check-block.sh script.
>>>
>>> Some cases still need to be checked first, though: iotests need bash and
>>> GNU sed (otherwise they fail), and if gprof is enabled, it spoils the
>>> output of some test cases causing them to fail. So if we detect that one
>>> of the required programs is missing or that gprof is enabled, we still
>>> have to skip the iotests to avoid failures.
>>>
>>> And finally, since we are using check-block.sh now again, this patch also
>>> removes the qemu-iotests-quick.sh script since we do not need that anymore
>>> (and having two shell wrapper scripts around the block tests seems rather
>>> confusing than helpful).
>>>
>>> Message-Id: <20190717111947.30356-4-thuth@redhat.com>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> [AJB: -makecheck to check-block.sh, move check-block to start and gate it]
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> This breaks when sanitizers are enabled.  There are leaks reported,
>> though I'm not sure if they are real, and in additions the warning lines
>> break qemu-iotests' output comparison.
> 
> D'oh, I already thought that it was too easy ;-) I'll have a look at it...

If I get that right, the problem only exists when compiling with Clang
and sanitizers enabled - Clang outputs lots of warnings that some things
are not implemented yet and then prints out these leak reports which are
likely false positives...

I've sent a patch now to disable the iotests during "make check" when
sanitizers are enabled. But I wonder whether we should maybe also check
for these incomplete sanitizer implementations in the configure script
to avoid to enable them in this case? (e.g. there are also lots of
warnings during "make check-qtest" in this case, which is somewhat ugly)

 Thomas


  reply	other threads:[~2019-08-23  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  8:54 [Qemu-devel] [PULL 0/3] Run iotests during "make check" Thomas Huth
2019-08-17  8:54 ` [Qemu-devel] [PULL 1/3] block: fix NetBSD qemu-iotests failure Thomas Huth
2019-08-17  8:54 ` [Qemu-devel] [PULL 2/3] tests: Run the iotests during "make check" again Thomas Huth
2019-08-22 22:34   ` Paolo Bonzini
2019-08-23  7:12     ` Thomas Huth
2019-08-23  8:59       ` Thomas Huth [this message]
2019-08-17  8:54 ` [Qemu-devel] [PULL 3/3] gitlab-ci: Remove qcow2 tests that are handled by "make check" already Thomas Huth
2019-08-19 14:08 ` [Qemu-devel] [PULL 0/3] Run iotests during "make check" Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2b15899-7836-3957-97dc-91cd70b96ea3@redhat.com \
    --to=thuth@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ymankad@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).