From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EA6C433B4 for ; Tue, 27 Apr 2021 16:45:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9F9461027 for ; Tue, 27 Apr 2021 16:45:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9F9461027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbQq3-0003b4-LR for qemu-devel@archiver.kernel.org; Tue, 27 Apr 2021 12:45:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbQmx-0002kL-Em for qemu-devel@nongnu.org; Tue, 27 Apr 2021 12:42:19 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:40453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbQmv-0004cK-Rc for qemu-devel@nongnu.org; Tue, 27 Apr 2021 12:42:19 -0400 Received: by mail-pg1-x52e.google.com with SMTP id b17so5734836pgh.7 for ; Tue, 27 Apr 2021 09:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=WpMfbPhLOQscSZoBg+QKpJl3Np9ZqmkvmrxNZaSbj3s=; b=ZopxJGeLbYsyFX/BNNTMWfsQPdOrH6UOvSbbGCF+NLul2wBkS4KaUtDtubd67BbQT2 1e4Wk1a/NW+7yYwtB9Zb1KMIteUC7bUr4hehnB72tmYnHoTzisRq2hWWmCQzo4IXP9hi AhcFFnZsfXfL0NUwzZOrEh3u1axBKufyIBCdTYjYP8x5BNngHNLes88RNgLjOQBKvXFu SRqYTGWN0SufcvK0l+UBpRoaCXL56jjq6h/A2UV8xK5J6P1HXI3YahdwpMmrRT1QyxI3 dT74uYYteGH51wxAD6ldNwrAxubG3ZrJW+MtGMCDVm51zeo2XuQdD1yvMw9Mbsp/65Rj NyEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WpMfbPhLOQscSZoBg+QKpJl3Np9ZqmkvmrxNZaSbj3s=; b=Rs2+mgUJv3ZBsCIe9DhCOufUYm8I6Q5JVbZD6qhmoFX+n9xAXwnGQDDDMDLuLPuTEr xo7MbK2JXcP9nAOJ3HU/ZxjN1qVbsQBxqDHGiVq+maMdLTZedGHPj8suHRNSsLsNzm09 0sBeRO+syuFZtqD1ASbc2XCnf/4CC3avr4MhSNvG1z8kI8zEWNObL1hG7ICr543X/TzN eR5ccm71+S6Ub78Y8qTsXKKrtaJMIZwFAXu3H+dwx+HsEBMVz2HkQjfFDeLbkeRO0kVm fxvyVM49zjeYPa2t77uRTryPi43Am5joSXgjIYrh05zWXYXAERI58fuQdayPrDQDnSfI d5Ww== X-Gm-Message-State: AOAM532ik0mORrisCxQRCKui078aZWyJH2zqvvJYjYfPhLLZTYsFSCLX Q87O71fehNJbx+aYV6yxtoq55xhNkr14Hg== X-Google-Smtp-Source: ABdhPJxKGyM+1SVRe2a3pz3wPeobik0+0Jx1qXn+P/AFVs+7xhyMtChAbY/Ly9eeA/w5ezDMIRDHLA== X-Received: by 2002:a63:d143:: with SMTP id c3mr22169045pgj.99.1619541736223; Tue, 27 Apr 2021 09:42:16 -0700 (PDT) Received: from [192.168.1.11] ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id o127sm3101485pfd.147.2021.04.27.09.42.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Apr 2021 09:42:15 -0700 (PDT) Subject: Re: [PATCH 03/13] target/arm: Make functions used by m-nocp global To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210413160759.5917-1-peter.maydell@linaro.org> <20210413160759.5917-4-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Tue, 27 Apr 2021 09:42:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210413160759.5917-4-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/13/21 9:07 AM, Peter Maydell wrote: > We want to split out the .c.inc files which are currently included > into translate.c so they are separate compilation units. To do this > we need to make some functions which are currently file-local to > translate.c have global scope; create a translate-a32.h paralleling > the existing translate-a64.h as a place for these declarations to > live, so that code moved into the new compilation units can call > them. > > The functions made global here are those required by the > m-nocp.decode functions, except that I have converted the whole > family of {read,write}_neon_element* and also both the load_cpu and > store_cpu functions for consistency, even though m-nocp only wants a > few functions from each. > > Signed-off-by: Peter Maydell > --- > target/arm/translate-a32.h | 57 ++++++++++++++++++++++++++++++++++ > target/arm/translate.c | 39 +++++------------------ > target/arm/translate-vfp.c.inc | 2 +- > 3 files changed, 65 insertions(+), 33 deletions(-) > create mode 100644 target/arm/translate-a32.h Reviewed-by: Richard Henderson r~