From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: "qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "fam@euphon.net" <fam@euphon.net>,
"kwolf@redhat.com" <kwolf@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
"quintela@redhat.com" <quintela@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>
Subject: Re: [PATCH 0/5] fix migration with bitmaps and mirror
Date: Mon, 2 Dec 2019 14:29:54 +0000 [thread overview]
Message-ID: <e4cc9d3d-ca5c-424d-468e-515783094c49@virtuozzo.com> (raw)
In-Reply-To: <20191004154701.3202-1-vsementsov@virtuozzo.com>
ping
04.10.2019 18:46, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> It's a continuation for
> "bitmap migration bug with -drive while block mirror runs"
> <315cff78-dcdb-a3ce-2742-da3cc9f0ca97@redhat.com>
> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg07241.html
>
> The problem is that bitmaps migrated to node with same node-name or
> blk-parent name. And currently only the latter actually work in libvirt.
> And with mirror-top filter it doesn't work, because
> bdrv_get_device_or_node_name don't go through filters.
>
> Fix this by handling filtered children of block backends in separate.
>
> Max Reitz (1):
> block: Mark commit and mirror as filter drivers
>
> Vladimir Sementsov-Ogievskiy (4):
> migretion/block-dirty-bitmap: refactor init_dirty_bitmap_migration
> block/dirty-bitmap: add bdrv_has_named_bitmaps helper
> migration/block-dirty-bitmap: fix bitmaps migration during mirror job
> iotests: 194: test also migration of dirty bitmap
>
> include/block/block_int.h | 8 ++-
> include/block/dirty-bitmap.h | 1 +
> block/commit.c | 2 +
> block/dirty-bitmap.c | 13 ++++
> block/mirror.c | 2 +
> migration/block-dirty-bitmap.c | 118 +++++++++++++++++++++++----------
> tests/qemu-iotests/194 | 14 ++--
> tests/qemu-iotests/194.out | 6 ++
> 8 files changed, 121 insertions(+), 43 deletions(-)
>
--
Best regards,
Vladimir
prev parent reply other threads:[~2019-12-02 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:46 [PATCH 0/5] fix migration with bitmaps and mirror Vladimir Sementsov-Ogievskiy
2019-10-04 15:46 ` [PATCH 1/5] block: Mark commit and mirror as filter drivers Vladimir Sementsov-Ogievskiy
2019-10-04 15:46 ` [PATCH 2/5] migretion/block-dirty-bitmap: refactor init_dirty_bitmap_migration Vladimir Sementsov-Ogievskiy
2019-10-04 15:46 ` [PATCH 3/5] block/dirty-bitmap: add bdrv_has_named_bitmaps helper Vladimir Sementsov-Ogievskiy
2019-10-04 15:47 ` [PATCH 4/5] migration/block-dirty-bitmap: fix bitmaps migration during mirror job Vladimir Sementsov-Ogievskiy
2019-10-04 15:47 ` [PATCH 5/5] iotests: 194: test also migration of dirty bitmap Vladimir Sementsov-Ogievskiy
2019-12-02 14:29 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4cc9d3d-ca5c-424d-468e-515783094c49@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).