From: "Klaus Jensen" <its@irrelevant.dk>
To: "Keith Busch" <kbusch@kernel.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
Gollu Appalanaidu <anaidu.gollu@samsung.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH RFC 3/3] hw/block/nvme: end-to-end data protection
Date: Fri, 18 Dec 2020 19:24:58 +0100 [thread overview]
Message-ID: <e4f59d92-eb82-4fc5-88d7-8ccdfdf9aa5e@www.fastmail.com> (raw)
In-Reply-To: <20201218180806.GC8722@redsun51.ssa.fujisawa.hgst.com>
On Fri, Dec 18, 2020, at 19:08, Keith Busch wrote:
> On Thu, Dec 17, 2020 at 10:02:22PM +0100, Klaus Jensen wrote:
> > static uint16_t nvme_rw(NvmeCtrl *n, NvmeRequest *req)
> > {
> > NvmeRwCmd *rw = (NvmeRwCmd *)&req->cmd;
> > NvmeNamespace *ns = req->ns;
> > uint32_t nlb = (uint32_t)le16_to_cpu(rw->nlb) + 1;
> > uint64_t slba = le64_to_cpu(rw->slba);
> > + uint16_t ctrl = le16_to_cpu(rw->control);
> >
> > uint64_t data_size = nvme_l2b(ns, nlb);
> > + uint64_t real_data_size = data_size;
> > uint64_t data_offset = nvme_l2b(ns, slba);
> > enum BlockAcctType acct = req->cmd.opcode == NVME_CMD_WRITE ?
> > BLOCK_ACCT_WRITE : BLOCK_ACCT_READ;
>
> Since this is right in the middle of the nvme read/write path, and we
> have the outstanding ZNS stuff intermixed here, could we possibly
> converge on the ZNS solution first, and rebase new IO path capabilities
> on a ZNS enabled tree?
>
Yes, absolutely. We marked this RFC to get some discussion going and we got that :)
Will definitely merge zns first :)
next prev parent reply other threads:[~2020-12-18 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 21:02 [PATCH RFC 0/3] hw/block/nvme: dif-based end-to-end data protection support Klaus Jensen
2020-12-17 21:02 ` [PATCH RFC 1/3] nvme: add support for extended LBAs Klaus Jensen
2020-12-17 21:02 ` [PATCH RFC 2/3] hw/block/nvme: refactor nvme_dma Klaus Jensen
2020-12-17 21:02 ` [PATCH RFC 3/3] hw/block/nvme: end-to-end data protection Klaus Jensen
2020-12-18 18:08 ` Keith Busch
2020-12-18 18:24 ` Klaus Jensen [this message]
2020-12-17 21:14 ` [PATCH RFC 0/3] hw/block/nvme: dif-based end-to-end data protection support Keith Busch
2020-12-18 9:39 ` Klaus Jensen
2020-12-18 17:50 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f59d92-eb82-4fc5-88d7-8ccdfdf9aa5e@www.fastmail.com \
--to=its@irrelevant.dk \
--cc=anaidu.gollu@samsung.com \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).