From: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: keith.busch@intel.com, kwolf@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH v1] block/nvme: introduce PMR support from NVMe 1.4 spec
Date: Wed, 19 Feb 2020 13:25:54 -0700 [thread overview]
Message-ID: <e5672095-a9ce-5098-bcfc-e71107b9f1d7@linux.intel.com> (raw)
In-Reply-To: <158207442698.20350.5846437537237258589@a1bbccc8075a>
On 2/18/20 6:07 PM, no-reply@patchew.org wrote:
> === TEST SCRIPT BEGIN ===
> #! /bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-mingw@fedora J=14 NETWORK=1
> === TEST SCRIPT END ===
>
> CC hw/display/sii9022.o
> CC hw/display/ssd0303.o
> /tmp/qemu-test/src/hw/block/nvme.c: In function 'nvme_pmr_read':
> /tmp/qemu-test/src/hw/block/nvme.c:1342:15: error: implicit declaration of function 'msync'; did you mean 'fsync'? [-Werror=implicit-function-declaration]
> ret = msync(n->pmrbuf, n->f_pmr_size, MS_SYNC);
> ^~~~~
> fsync
> /tmp/qemu-test/src/hw/block/nvme.c:1342:15: error: nested extern declaration of 'msync' [-Werror=nested-externs]
> /tmp/qemu-test/src/hw/block/nvme.c:1342:47: error: 'MS_SYNC' undeclared (first use in this function)
> ret = msync(n->pmrbuf, n->f_pmr_size, MS_SYNC);
> ^~~~~~~
> /tmp/qemu-test/src/hw/block/nvme.c:1342:47: note: each undeclared identifier is reported only once for each function it appears in
> /tmp/qemu-test/src/hw/block/nvme.c: In function 'nvme_realize':
> /tmp/qemu-test/src/hw/block/nvme.c:1413:21: error: implicit declaration of function 'mmap'; did you mean 'max'? [-Werror=implicit-function-declaration]
> n->pmrbuf = mmap(NULL, n->f_pmr_size,
> ^~~~
This patch seems to fail on cross-compilation for Windows env.
I plan to submit second version of this patch which will conditionally
support PMR for Linux environment only. It should take care of this problem.
Do you see any better fix for that?
next prev parent reply other threads:[~2020-02-19 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 22:48 [PATCH v1] block/nvme: introduce PMR support from NVMe 1.4 spec Andrzej Jakowski
2020-02-19 1:07 ` no-reply
2020-02-19 20:25 ` Andrzej Jakowski [this message]
2020-02-21 13:45 ` Stefan Hajnoczi
2020-02-21 15:36 ` Andrzej Jakowski
2020-02-21 17:31 ` Stefan Hajnoczi
2020-02-21 17:50 ` Dr. David Alan Gilbert
2020-02-21 18:29 ` Stefan Hajnoczi
2020-02-21 19:32 ` Stefan Hajnoczi
2020-02-21 20:20 ` Andrzej Jakowski
2020-02-21 18:45 ` Dr. David Alan Gilbert
2020-02-21 20:19 ` Andrzej Jakowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5672095-a9ce-5098-bcfc-e71107b9f1d7@linux.intel.com \
--to=andrzej.jakowski@linux.intel.com \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).